Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAVAND-1564: do not resume route refreshes after routes are changed #7581

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

dzinad
Copy link
Contributor

@dzinad dzinad commented Oct 25, 2023

BP of #7579.

@dzinad dzinad requested a review from a team as a code owner October 25, 2023 11:22
@dzinad dzinad enabled auto-merge (rebase) October 25, 2023 11:22
@github-actions
Copy link

Changelog

Features

Bug fixes and improvements

  • Fixed an issue where route refreshes might not have been paused after invoking RouteRefreshController#pauseRouteRefreshes. [#dd](https://github.com/mapbox/mapbox-navigation-android/pull/dd)

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

  • The app is now considered as the one in active navigation only when an active route is set to MapboxNavigation. Previously it was always considered active. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)
  • When Android Auto host tells the app to stop active navigation because another app starts navigating, now SDK will enter FreeDrive mode instead of stopping trip session completely. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #7581 (b02ed9d) into release-v2.17 (7d14406) will decrease coverage by 0.01%.
Report is 2 commits behind head on release-v2.17.
The diff coverage is 90.90%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             release-v2.17    #7581      +/-   ##
===================================================
- Coverage            74.15%   74.15%   -0.01%     
- Complexity            6153     6154       +1     
===================================================
  Files                  830      830              
  Lines                32936    32936              
  Branches              3930     3933       +3     
===================================================
- Hits                 24424    24423       -1     
  Misses                6978     6978              
- Partials              1534     1535       +1     
Files Coverage Δ
...core/routerefresh/PlannedRouteRefreshController.kt 99.07% <90.90%> (-0.93%) ⬇️

@dzinad dzinad merged commit 8ca566d into release-v2.17 Oct 25, 2023
1 of 4 checks passed
@dzinad dzinad deleted the NAVAND-1564-dd-cp branch October 25, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants