This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Adding try/catch to SnapshotNotificationActivity to catch IllegalStateException #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
reviewed
Oct 2, 2019
There was a problem hiding this comment.
What about we refactor the code a bit to avoid this issue? I would suggest introducing an inner class handling the click event and holding a reference to the style. This way we can avoid needing to call getStyle in the onMapClick event and we are sure we won't create two snapshots as the if check on mapSnapshotter will execute as expected
langsmith
force-pushed
the
ls-snapshotter-IllegalStateException-fix
branch
from
adaefcf to
95e2d0d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1136 by adding a try/catch to fix a crash. I was able to reproduce the crash by quickly tapping the map twice. The second tap throws the exception because the MapSnapshotter is already created and in the process of creating the snapshot.
The exception from
MapSnapshotter.javais now printed to the logcat and a cleaner message is displayed in a Toast.cc @JoelNieman