Adding try/catch to SnapshotNotificationActivity to fix crash

mapbox · Oct 2, 2019 · 95e2d0d · 95e2d0d
1 parent 3dadd83
commit 95e2d0d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/...ain/java/com/mapbox/mapboxandroiddemo/examples/snapshot/SnapshotNotificationActivity.java b/...ain/java/com/mapbox/mapboxandroiddemo/examples/snapshot/SnapshotNotificationActivity.java
@@ -8,6 +8,7 @@
 import android.graphics.Bitmap;
 import android.os.Build;
 import android.os.Bundle;
+import android.widget.Toast;
 
 import com.mapbox.mapboxandroiddemo.MainActivity;
 import com.mapbox.mapboxandroiddemo.R;
@@ -24,6 +25,7 @@
 import androidx.annotation.NonNull;
 import androidx.appcompat.app.AppCompatActivity;
 import androidx.core.app.NotificationCompat;
+import timber.log.Timber;
 
 import static android.app.PendingIntent.getActivity;
 
@@ -102,12 +104,18 @@ public void onStyleLoaded(@NonNull Style style) {
           mapSnapshotter.setSize(width, height);
           mapSnapshotter.setRegion(latLngBounds);
         }
-        mapSnapshotter.start(new MapSnapshotter.SnapshotReadyCallback() {
-          @Override
-          public void onSnapshotReady(MapSnapshot snapshot) {
-            createNotification(snapshot.getBitmap());
-          }
-        });
+        try {
+          mapSnapshotter.start(new MapSnapshotter.SnapshotReadyCallback() {
+            @Override
+            public void onSnapshotReady(MapSnapshot snapshot) {
+              createNotification(snapshot.getBitmap());
+            }
+          });
+        } catch (IllegalStateException exception) {
+          Timber.d(exception);
+          Toast.makeText(SnapshotNotificationActivity.this,
+              R.string.snapshotter_was_already_started, Toast.LENGTH_SHORT).show();
+        }
       }
     });
   }

diff --git a/MapboxAndroidDemo/src/main/res/values/activity_strings.xml b/MapboxAndroidDemo/src/main/res/values/activity_strings.xml
@@ -121,6 +121,7 @@
     <!--Tap on map instruction for toast-->
     <string name="tap_on_map_instruction">Tap anywhere on the map</string>
     <string name="tap_on_map_for_notification">Tap on map to get a notification with map image</string>
+    <string name="snapshotter_was_already_started">Snapshotter was already started</string>
 
     <string name="san_francisco">San Francisco</string>
     <string name="los_angeles">Los Angeles</string>