Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore deletes that do not match #298

Closed
wants to merge 1 commit into from

Conversation

RubenVerborgh
Copy link
Member

Delete operations that do not match any triples should silently succeed instead of erroring.

See nodeSolidServer/node-solid-server#1085

@RubenVerborgh RubenVerborgh force-pushed the fix/no-error-on-empty-delete branch from c24c038 to 23e6b3f Compare February 6, 2019 09:54
@RubenVerborgh
Copy link
Member Author

From a discussion with @timbl:

It is a critical part of the architecture that patches which delete non existent triples fail.

Otherwise we have no control of concurrent editing

@RubenVerborgh
Copy link
Member Author

Alternative implementation in #299

@jeff-zucker
Copy link
Contributor

There was lengthy discussion on this with the consensus being that an attempt to delete a triple that doesn't exist should return a 409 because it might indicate multiple editors on the same resource, see nodeSolidServer/node-solid-server#1085 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants