Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PATCH requests with non-matching deletions #1086

Closed
wants to merge 2 commits into from
Closed

Fix PATCH requests with non-matching deletions #1086

wants to merge 2 commits into from

Conversation

RubenVerborgh
Copy link
Contributor

Fixes #1085

Depends on linkeddata/rdflib.js#298

@RubenVerborgh RubenVerborgh self-assigned this Feb 6, 2019
kjetilk
kjetilk requested changes Feb 6, 2019
View reviewed changes
Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the tests are failing, so it doesn't quite work as intended?

@kjetilk
Copy link
Member

kjetilk commented Feb 6, 2019

Ah, got it, it relies on changes in rdflib. Indeed, then approving, since the changes here LGTM.

kjetilk
kjetilk requested changes Feb 15, 2019
View reviewed changes
Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerns have been voiced that this will break too much, and that the actual problem is a design flaw in SPARQL Update. Thus setting the review so that it doesn't go in before we have a better solution.

@RubenVerborgh
Copy link
Contributor Author

Discussion continued in linkeddata/rdflib.js#299

@kjetilk kjetilk closed this Feb 18, 2019
@kjetilk kjetilk reopened this Feb 18, 2019
@kjetilk kjetilk mentioned this pull request Feb 18, 2019
Closed
@kjetilk kjetilk closed this Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjetilk kjetilk kjetilk requested changes

@rubensworks rubensworks rubensworks approved these changes

@timbl timbl Awaiting requested review from timbl

Assignees

@RubenVerborgh RubenVerborgh

Labels
bug on-hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RubenVerborgh @kjetilk @rubensworks