Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinity commits by license_finder job #120

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

masutaka
Copy link
Member

@masutaka masutaka commented Dec 2, 2024

Summary

Fix the following infinite commits of frontend/docs/packages-license.md caused by the infinite execution of the license_finder job.

For examples:

Related Issue

This PR fixs the enbug of #94 .

Changes

cancel-in-progress: true has been removed to default to false. New license_finder jobs are not canceled when they are created.
The serial execution of license_finder jobs is maintained.

Testing

Looks okay.
https://github.com/liam-hq/liam/actions/workflows/license-frontend.yml?query=branch%3Afix-infinity-runs-of-license-finder-job

Other Information

Nothing

@masutaka masutaka added the bug Something isn't working label Dec 2, 2024
@masutaka masutaka self-assigned this Dec 2, 2024
@masutaka masutaka marked this pull request as ready for review December 2, 2024 04:21
@masutaka masutaka requested a review from a team as a code owner December 2, 2024 04:21
@masutaka masutaka requested review from hoshinotsuyoshi, FunamaYukina, junkisai, MH4GF and sasamuku and removed request for a team December 2, 2024 04:21
Copy link
Member

@MH4GF MH4GF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@masutaka masutaka added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 78be4d7 Dec 2, 2024
8 checks passed
@masutaka masutaka deleted the fix-infinity-runs-of-license-finder-job branch December 2, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants