Dockerfiles: bump eve-alpine image, eve-cross-compilers and eve-dom0-ztools #4334

christoph-zededa · 2024-10-10T17:40:30Z

Sync eve-alpine image across all packages with the latest image.

> docker inspect lfedge/eve-alpine:1f7685f95a475c6bbe682f0b976f12180b6c8726 | grep -i create
        "Created": "2024-05-14T20:55:51.41185787Z",

> docker inspect lfedge/eve-alpine:82df60e43ab9f8c935584b8c7b4d0a4b0271d608 | grep -i create
        "Created": "2024-09-05T21:14:17.854134914Z",

christoph-zededa · 2024-10-10T17:44:57Z

@deitch so after #4220 (comment) now bumping the installer makes problems? ;-)

#12 [build  2/22] RUN eve-alpine-deploy.sh
#12 0.241 ERROR: unable to select packages:
#12 0.242   so:libhd.so.21 (no such package):
#12 0.244     required by: hwinfo-21.81-r0[so:libhd.so.21]
#12 0.244   i2c-tools (no such package):
#12 0.244     required by: i2c-tools-dev-4.3-r1[i2c-tools=4.3-r1]
#12 0.244   so:libtss2-mu.so.0 (no such package):
#12 0.244     required by: tpm2-tss-sys-3.1.0-r0[so:libtss2-mu.so.0]
#12 0.244                  tpm2-tss-fapi-3.1.0-r0[so:libtss2-mu.so.0]
#12 0.244                  tpm2-tss-esys-3.1.0-r0[so:libtss2-mu.so.0]
#12 0.244   tpm2-tss-mu (no such package):
#12 0.244     required by: tpm2-tss-dev-3.1.0-r0[tpm2-tss-mu=3.1.0-r0]
#12 0.244   tpm2-tss-tcti-cmd (no such package):
#12 0.244     required by: tpm2-tss-dev-3.1.0-r0[tpm2-tss-tcti-cmd=3.1.0-r0]
#12 0.244   tpm2-tss-tcti-device (no such package):
#12 0.244     required by: tpm2-tss-dev-3.1.0-r0[tpm2-tss-tcti-device=3.1.0-r0]
#12 0.244   tpm2-tss-tcti-mssim (no such package):
#12 0.244     required by: tpm2-tss-dev-3.1.0-r0[tpm2-tss-tcti-mssim=3.1.0-r0]
#12 0.244   tpm2-tss-tcti-pcap (no such package):
#12 0.244     required by: tpm2-tss-dev-3.1.0-r0[tpm2-tss-tcti-pcap=3.1.0-r0]
#12 0.244   tpm2-tss-tcti-swtpm (no such package):
#12 0.244     required by: tpm2-tss-dev-3.1.0-r0[tpm2-tss-tcti-swtpm=3.1.0-r0]
#12 ERROR: process "/bin/ash -eo pipefail -c eve-alpine-deploy.sh" did not complete successfully: exit code: 15

OhmSpectator

We have to automate the check on proper image hashes...

deitch · 2024-10-10T18:31:45Z

@deitch so after #4220 (comment) now bumping the installer makes problems? ;-)

That dependency from mkverification must have moved into installer. We should check the installer to see if it is something we still actually need.

christoph-zededa · 2024-10-11T09:26:03Z

We have to automate the check on proper image hashes...

there is https://github.com/lf-edge/eve-build-tools/blob/main/src/dockerfile-from-checker/main.go but it needs some changes

OhmSpectator · 2024-10-11T09:27:56Z

We have to automate the check on proper image hashes...

there is https://github.com/lf-edge/eve-build-tools/blob/main/src/dockerfile-from-checker/main.go but it needs some changes

I thought about a GH action that can report inconsistency in the hashes in different components.

christoph-zededa · 2024-10-11T09:31:26Z

We have to automate the check on proper image hashes...

there is https://github.com/lf-edge/eve-build-tools/blob/main/src/dockerfile-from-checker/main.go but it needs some changes

I thought about a GH action that can report inconsistency in the hashes in different components.

if you can run it from a GH action, then it should work, just run it with:

dockerfile-checker ./ -i ./eve-tools/bpftrace-compiler/Dockerfile -i ./pkg/optee-os/Dockerfile -i pkg/bsp-imx/Dockerfile -i pkg/vtpm/Dockerfile

because there are still some deviations:

tags differ for image lfedge/eve-dom0-ztools:b8eaeec19d373228a4a842374e5de0d50f050853 in files /home/christoph/projects/eve/pkg/vtpm/Dockerfile and /home/christoph/projects/eve/pkg/pillar/Dockerfile
tags differ for image lfedge/eve-cross-compilers:2a1d062fce410865e7024a83de327a68e52db26c in files /home/christoph/projects/eve/pkg/pillar/Dockerfile and /home/christoph/projects/eve/pkg/optee-os/Dockerfile
tags differ for image alpine:3.20 in files /home/christoph/projects/eve/eve-tools/bpftrace-compiler/Dockerfile and /home/christoph/projects/eve/eve-tools/bpftrace-compiler/root/Dockerfile

OhmSpectator · 2024-10-11T09:58:41Z

because there are still some deviations:

Do we have a good reason for these deviations?

christoph-zededa · 2024-10-11T10:03:57Z

because there are still some deviations:

Do we have a good reason for these deviations?

For bpftrace-compiler I just want to use the newer alpine as we will move to it anyways, so I didn't start with the old one.

For the other ones I don't know.

Makefile

rene · 2024-10-11T10:17:07Z

tools/dockerfile-from-checker/main.go

+}
+
+func main() {
+	rootCmd.Flags().StringSliceP("ignore-files", "i", []string{}, "ignores specified Dockerfile; can be used several times")


Would be good to have a minimal description of what the tool does...

OhmSpectator · 2024-10-11T10:17:02Z

tools/dockerfile-from-checker/go.sum

In Python, it would be fewer than 100 lines and no huge go.sum files. =(
But let it be if we already have it implemented...

But can python evaluate the dockerfile variables?

Ah, I got the idea... You parse AST there to get the values. Okay-okay.

OhmSpectator · 2024-10-11T10:39:26Z

I would suggest to make it in two different PRs: the version bump (as the original version) and new check introduction.

OhmSpectator · 2024-10-11T14:47:47Z

Now I really like it.
But I'm a little bit confused. How is this PR affected by #4340? Shouldn't we merge this one before #4340?

christoph-zededa · 2024-10-11T14:51:13Z

Now I really like it. But I'm a little bit confused. How is this PR affected by #4340? Shouldn't we merge this one before #4340?

Once #4340 is merged, the installer/Dockerfile can be removed from the list of ignored Dockerfiles. Then only bpftrace is left (until we bump everything to alpine 3.20).

deitch · 2024-10-11T14:51:25Z

Probably 4340 first, but I can rebase that one next week if this goes in.

OhmSpectator · 2024-10-11T15:34:55Z

Probably 4340 first, but I can rebase that one next week if this goes in.

Let's merge this PR first, as it's already in good shape. And rebase #4334 later (it should also remove the ignoring of the pkg/installer).

OhmSpectator · 2024-10-11T15:37:12Z

Why are the Eden tests skipped all the time?.. @yash-zededa, any idea?

yash-zededa · 2024-10-11T15:49:15Z

Why are the Eden tests skipped all the time?.. @yash-zededa, any idea?

It's because of the WF modifications.

@christoph-zededa would it be possible to create a separate PR for the WF and Makefile

OhmSpectator · 2024-10-11T15:54:05Z

Why are the Eden tests skipped all the time?.. @yash-zededa, any idea?

It's because of the WF modifications.

@christoph-zededa would it be possible to create a separate PR for the WF and Makefile

@yash-zededa, do we skip the tests run if workflow files are changed? I would expect the tests to be skipped if ONLY workflows are changed... Do you think we could fix it?

yash-zededa · 2024-10-11T16:02:37Z

Why are the Eden tests skipped all the time?.. @yash-zededa, any idea?

It's because of the WF modifications.
@christoph-zededa would it be possible to create a separate PR for the WF and Makefile

@yash-zededa, do we skip the tests run if workflow files are changed? I would expect the tests to be skipped if ONLY workflows are changed... Do you think we could fix it?

I think so, I will work on the logic where in we run tests for PR which has WF as well as code changes but ideally for all the new WF’s/modification to the existing one’s should be part of separate PR since it will help us with a clean history.

christoph-zededa · 2024-10-11T16:07:00Z

@christoph-zededa would it be possible to create a separate PR for the WF and Makefile

like #4341 ?

OhmSpectator · 2024-10-11T16:26:41Z

@christoph-zededa would it be possible to create a separate PR for the WF and Makefile

like #4341 ?

Merged. Rebase this one, please.

OhmSpectator · 2024-10-14T06:57:27Z

Makefile

-		-i pkg/udev/Dockerfile \
-		-i pkg/xen-tools/Dockerfile \
-		-i pkg/xen/Dockerfile
+		-i pkg/installer/Dockerfile


Should it be rebased to use the new variables introduced by @deitch, I guess?

Yup. And I just opened a PR based on that to bump the alpines as well, but remove pkg/installer from the exceptions list 😄

Not sure if that helps, hinders or is neutral to this one. Feel free to throw mine away if needed.

I think it's best to wait for rebase until #4348 is merged ...

I think it's best to wait for rebase until #4348 is merged ...

And that PR is dependent on #4350

OhmSpectator · 2024-10-15T17:16:53Z

@christoph-zededa, it's time to rebase! =) #4348 is merged!

Sync eve-alpine image across all packages with the latest image. Signed-off-by: Christoph Ostarek <[email protected]>

bsp-imx, vtpm and optee-os for cross-compilers and ztools in order to use the same image tag everywhere Signed-off-by: Christoph Ostarek <[email protected]>

eriknordmark

LGTM

christoph-zededa requested review from OhmSpectator, rene and eriknordmark as code owners October 10, 2024 17:40

christoph-zededa force-pushed the eve-alpine_use_same_image branch from df51ff3 to 0cca675 Compare October 10, 2024 17:40

github-actions bot requested review from rucoder and shjala October 10, 2024 17:40

christoph-zededa force-pushed the eve-alpine_use_same_image branch from 0cca675 to 527cd64 Compare October 10, 2024 17:41

OhmSpectator approved these changes Oct 10, 2024

View reviewed changes

christoph-zededa requested a review from deitch as a code owner October 11, 2024 09:55

github-actions bot requested review from jsfakian and OhmSpectator October 11, 2024 09:55

christoph-zededa force-pushed the eve-alpine_use_same_image branch 2 times, most recently from 965e099 to 4e71198 Compare October 11, 2024 09:58

christoph-zededa changed the title ~~Dockerfiles: bump eve-alpine image~~ Dockerfiles: bump eve-alpine image and check for future inconsistencies Oct 11, 2024

rene reviewed Oct 11, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

OhmSpectator reviewed Oct 11, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

rene reviewed Oct 11, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

rene reviewed Oct 11, 2024

View reviewed changes

OhmSpectator reviewed Oct 11, 2024

View reviewed changes

christoph-zededa force-pushed the eve-alpine_use_same_image branch from 4e71198 to 0f94dd8 Compare October 11, 2024 10:35

github-actions bot requested review from OhmSpectator and rene October 11, 2024 10:35

github-actions bot requested a review from yash-zededa October 11, 2024 14:26

christoph-zededa force-pushed the eve-alpine_use_same_image branch 2 times, most recently from ee69756 to 8595e96 Compare October 11, 2024 14:39

OhmSpectator approved these changes Oct 11, 2024

View reviewed changes

christoph-zededa mentioned this pull request Oct 11, 2024

tools: introduce dockerfile-from-checker #4341

Merged

christoph-zededa force-pushed the eve-alpine_use_same_image branch from 8595e96 to 9969d1a Compare October 11, 2024 16:30

github-actions bot requested a review from OhmSpectator October 11, 2024 16:31

christoph-zededa changed the title ~~Dockerfiles: bump eve-alpine image and check for future inconsistencies~~ Dockerfiles: bump eve-alpine image, eve-cross-compilers and eve-dom0-ztools Oct 11, 2024

OhmSpectator approved these changes Oct 11, 2024

View reviewed changes

christoph-zededa mentioned this pull request Oct 13, 2024

Remove dockerfile from checker lf-edge/eve-build-tools#30

Open

OhmSpectator reviewed Oct 14, 2024

View reviewed changes

christoph-zededa force-pushed the eve-alpine_use_same_image branch from 9969d1a to edf97b6 Compare October 14, 2024 10:07

github-actions bot requested a review from OhmSpectator October 14, 2024 10:08

christoph-zededa added 2 commits October 15, 2024 19:20

Dockerfiles: bump remaining eve-alpine based images

30d480a

Sync eve-alpine image across all packages with the latest image. Signed-off-by: Christoph Ostarek <[email protected]>

Dockerfiles: bump several images

742d654

bsp-imx, vtpm and optee-os for cross-compilers and ztools in order to use the same image tag everywhere Signed-off-by: Christoph Ostarek <[email protected]>

christoph-zededa force-pushed the eve-alpine_use_same_image branch from edf97b6 to 742d654 Compare October 15, 2024 17:23

christoph-zededa requested a review from milan-zededa as a code owner October 15, 2024 17:23

eriknordmark approved these changes Oct 15, 2024

View reviewed changes

eriknordmark merged commit 7a045f6 into lf-edge:master Oct 16, 2024
39 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dockerfiles: bump eve-alpine image, eve-cross-compilers and eve-dom0-ztools #4334

Dockerfiles: bump eve-alpine image, eve-cross-compilers and eve-dom0-ztools #4334

christoph-zededa commented Oct 10, 2024

christoph-zededa commented Oct 10, 2024

OhmSpectator left a comment

deitch commented Oct 10, 2024

christoph-zededa commented Oct 11, 2024

OhmSpectator commented Oct 11, 2024 •

edited

Loading

christoph-zededa commented Oct 11, 2024

OhmSpectator commented Oct 11, 2024

christoph-zededa commented Oct 11, 2024

rene Oct 11, 2024

OhmSpectator Oct 11, 2024 •

edited

Loading

christoph-zededa Oct 11, 2024

OhmSpectator Oct 11, 2024

OhmSpectator commented Oct 11, 2024

OhmSpectator commented Oct 11, 2024

christoph-zededa commented Oct 11, 2024

deitch commented Oct 11, 2024

OhmSpectator commented Oct 11, 2024

OhmSpectator commented Oct 11, 2024

yash-zededa commented Oct 11, 2024

OhmSpectator commented Oct 11, 2024

yash-zededa commented Oct 11, 2024

christoph-zededa commented Oct 11, 2024

OhmSpectator commented Oct 11, 2024

OhmSpectator Oct 14, 2024

deitch Oct 14, 2024

christoph-zededa Oct 14, 2024

OhmSpectator Oct 14, 2024

OhmSpectator commented Oct 15, 2024

eriknordmark left a comment

Dockerfiles: bump eve-alpine image, eve-cross-compilers and eve-dom0-ztools #4334

Dockerfiles: bump eve-alpine image, eve-cross-compilers and eve-dom0-ztools #4334

Conversation

christoph-zededa commented Oct 10, 2024

christoph-zededa commented Oct 10, 2024

OhmSpectator left a comment

Choose a reason for hiding this comment

deitch commented Oct 10, 2024

christoph-zededa commented Oct 11, 2024

OhmSpectator commented Oct 11, 2024 • edited Loading

christoph-zededa commented Oct 11, 2024

OhmSpectator commented Oct 11, 2024

christoph-zededa commented Oct 11, 2024

rene Oct 11, 2024

Choose a reason for hiding this comment

OhmSpectator Oct 11, 2024 • edited Loading

Choose a reason for hiding this comment

christoph-zededa Oct 11, 2024

Choose a reason for hiding this comment

OhmSpectator Oct 11, 2024

Choose a reason for hiding this comment

OhmSpectator commented Oct 11, 2024

OhmSpectator commented Oct 11, 2024

christoph-zededa commented Oct 11, 2024

deitch commented Oct 11, 2024

OhmSpectator commented Oct 11, 2024

OhmSpectator commented Oct 11, 2024

yash-zededa commented Oct 11, 2024

OhmSpectator commented Oct 11, 2024

yash-zededa commented Oct 11, 2024

christoph-zededa commented Oct 11, 2024

OhmSpectator commented Oct 11, 2024

OhmSpectator Oct 14, 2024

Choose a reason for hiding this comment

deitch Oct 14, 2024

Choose a reason for hiding this comment

christoph-zededa Oct 14, 2024

Choose a reason for hiding this comment

OhmSpectator Oct 14, 2024

Choose a reason for hiding this comment

OhmSpectator commented Oct 15, 2024

eriknordmark left a comment

Choose a reason for hiding this comment

OhmSpectator commented Oct 11, 2024 •

edited

Loading

OhmSpectator Oct 11, 2024 •

edited

Loading