-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dockerfile from checker #30
base: main
Are you sure you want to change the base?
Remove dockerfile from checker #30
Conversation
c3dfe58
to
93e6efc
Compare
It can be removed as it is now in the eve repository. Signed-off-by: Christoph Ostarek <[email protected]>
93e6efc
to
88011bf
Compare
Why are we moving this out of here and into |
Besides lf-edge/eve#4334 (comment) there are some more reasons:
|
The The argument you are making is basically for a monorepo with everything in it. We cannot afford that. Let's say that tomorrow there is a new version of the dockerfile frontend. Do you really need to go through all of the long slow eve CI, and tie up runners, just to update that tool? You might want to once you are sure the tool is ready, but not before that. That is what libraries are about: modularization. EVE repo is way too big and heavy. We didn't like moving the api out to eve-api repo either, but it was critically necessary. |
No everything. F.e. no gcc sources or kernel sources. Also we just added another 4k files for rust ...
No, that's why I am also working on lf-edge/eve#4202 (slowly working on it though) Are there any other reasons why we cannot afford that? Okay, so you are advertising to use a multi-repo strategy, but unfortunately we lack the infrastructure to do so:
|
We already do use a multi-repo strategy, and a mono-repo, at the same time. some of it always will be multi-repo: kernel, eve-api, libs. There are solid reasons for it. |
No description provided.