Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo the reverted changes in #4714 #4737

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Sep 16, 2024

Summary

This pull request addresses the issue where the text 'This field is required' is displayed when bulk editing learning activities.
Fixes #4651

Reviewer guidance

How can a reviewer test these changes?

  1. Select multiple resources with different categories.
  2. Verify that the "mixed" tag is not displayed as a category.
  3. Verify that indeterminate state checkboxes are not displayed.
  4. Verify that the helper text is displayed: "You selected resources that have different categories. The categories you choose below will be added to all selected resources. This will not remove existing categories."
  5. Verify that the "save" button is enabled only if one or more boxes are checked.
  6. Verify that no validation is required, and no error message is displayed.

References

#4651

Summary

This pull request addresses the issue where the text 'This field is required' is displayed when bulk editing learning activities.
Fixes #4651

Reviewer guidance

How can a reviewer test these changes?

  1. Select multiple resources with different categories.
  2. Verify that the "mixed" tag is not displayed as a category.
  3. Verify that indeterminate state checkboxes are not displayed.
  4. Verify that the helper text is displayed: "You selected resources that have different categories. The categories you choose below will be added to all selected resources. This will not remove existing categories."
  5. Verify that no validation is required, and no error message is displayed.

References

#4651

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AllanOXDi! I just made some notes. Also noted that we still need to bring back the rest of the original PR, as we have only add the original changes in the EditBooleanMapModal file, but the changes in the rest of files are missing. You can check them here https://github.com/learningequality/studio/pull/4714/files.

if (value.includes(node.id)) {
const currentNode = this.getContentNode(node.id);
if (this.hasMixedCategories) {
Object.assign(fieldValue, currentNode[this.field] || {});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the comments here for future references.

// If we have mixed categories remain the old ones, and
// just add new categories if there are any

@AllanOXDi AllanOXDi marked this pull request as ready for review September 17, 2024 20:36
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AllanOXDi! Looks good to me!

@AllanOXDi AllanOXDi merged commit 7474aac into learningequality:unstable Sep 17, 2024
13 checks passed
@AllanOXDi AllanOXDi deleted the bulk_editting-fix branch September 17, 2024 20:42
@akolson akolson mentioned this pull request Sep 19, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable - Bulk edit learning activities - Seeing 'This field is required' validation message
2 participants