Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable - Bulk editing on a main folder level - It's possible to replace and remove preexisting categories #4748

Closed
pcenov opened this issue Sep 20, 2024 · 2 comments · Fixed by #4751
Assignees
Labels
P0 - critical Priority: Release blocker or regression

Comments

@pcenov
Copy link
Member

pcenov commented Sep 20, 2024

Observed behavior

This is a follow-up to #4737 - if I have a folder with multiple resources and folders and I select one of the available bulk editing options such as 'Edit categories', 'Edit levels' and 'Edit requirements' then I am able to actually remove or replace all of the existing categories. This is different from the bulk editing implementation when I have selected several resources in which case I see the text: You selected resources that have different categories. The categories you choose below will be added to all selected resources. This will not remove existing categories.

Expected behavior

This could be the desired behavior. To be further discussed.

Steps to reproduce the issue

  1. Go to https://unstable.studio.learningequality.org/en/accounts/#/ and sign in
  2. Open a channel with folders and all of the supported resources
  3. Select a folder containing several resources with different categories, levels and requirements
  4. Attempt to bulk edit those by modifying the main folder

Additional information

folder.mp4

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Sep 20, 2024

@radinamatic

@AlexVelezLl
Copy link
Member

Hmm in my opinion I think the problem would be because the message "Apply to all resources, folders and subfolders contained within the selected folders" could be confused between "set these categories and remove the rest of them" and "add these categories", what does "apply" mean?

I was thinking about what would happen if the behavior was modified and instead of setting and removing all the other categories, they were always added, regardless of whether or not there are mixed categories in the descendants. But I think that in that case a mistake by a user who mistakenly added an extra category and then wants to remove it would be somewhat tedious. Although perhaps less tedious than finding that the categories they already had in the descendants were removed? I think that in both cases an undo action is quite important in these bulk editions. Or at least a warning of "are you sure you want to..." before saving.

@AlexVelezLl AlexVelezLl self-assigned this Sep 24, 2024
@rtibbles rtibbles added this to the Studio: Bulk Editing Release milestone Sep 24, 2024
@rtibbles rtibbles added the P0 - critical Priority: Release blocker or regression label Sep 24, 2024
This was referenced Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants