-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CategoryTheory/Enriched/Ordinary/Limits): Add conical limits for enriched ordinary categories #20904
Open
joneugster
wants to merge
7
commits into
master
Choose a base branch
from
eugster/conical_limit_2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−6
Open
feat(CategoryTheory/Enriched/Ordinary/Limits): Add conical limits for enriched ordinary categories #20904
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4b410b8
chore(CategoryTheory/Enriched/Ordinary): create folder to allow API d…
joneugster f961132
update Mathlib.lean
joneugster 83b4fe1
fix
joneugster 071662b
add Enriched.IsConicalLimit
joneugster ab4188f
update Mathlib.lean
joneugster db68bab
remove unecessary import
joneugster dcb10f7
add docs; cleanup
joneugster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
Mathlib/CategoryTheory/Enriched/Ordinary/Limits/IsConicalLimit.lean
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/- | ||
Copyright (c) 2025 Jon Eugster. All rights reserved. | ||
Released under Apache 2.0 license as described in the file LICENSE. | ||
Authors: Emily Riehl, Dagur Asgeirsson, Jon Eugster | ||
-/ | ||
import Mathlib.CategoryTheory.Enriched.Ordinary.Basic | ||
|
||
/-! | ||
# Conical limits / enriched limits | ||
|
||
If `V` is a monoidal category and `C` a `V`-enriched ordinary category, | ||
a `V`-enriched limit, or "conical limit", is a limit cone `c` in `C` with | ||
the property that for every `X : C`, the cone obtained by applying the coyoneda | ||
functor `(X ⟶[V] -)` to `c` is a limit cone in `V`. | ||
-/ | ||
|
||
universe v₁ u₁ w v' v u u' | ||
|
||
namespace CategoryTheory.Enriched | ||
|
||
open Limits | ||
|
||
variable {J : Type u₁} [Category.{v₁} J] | ||
variable (V : outParam <| Type u') [Category.{v'} V] [MonoidalCategory V] | ||
variable {C : Type u} [Category.{v} C] [EnrichedOrdinaryCategory V C] | ||
variable {F : J ⥤ C} (c : Cone F) | ||
|
||
/-- | ||
A limit cone `c` in a `V`-enriched ordinary category `C` is a *`V`-enriched limit* | ||
(or *conical limit*) if for every `X : C`, the cone obtained by applying the coyoneda | ||
functor `(X ⟶[V] -)` to `c` is a limit cone in `V`. | ||
-/ | ||
structure IsConicalLimit where | ||
/-- A conical limit cone is a limit cone. -/ | ||
isLimit : IsLimit c | ||
/-- | ||
The cone obtained by applying the coyoneda functor `(X ⟶[V] -)` to `c` is a limit cone in `V`. | ||
-/ | ||
isConicalLimit (X : C) : IsLimit <| (eCoyoneda V X).mapCone c | ||
|
||
end CategoryTheory.Enriched |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
V
should be an explicit parameter toIsConicalLimit
. (This is what we have in the rest of the enriched category API, and I believe it should not change.)Could you also add references to the mathematical literature? and also some minimal API (like constructors which under suitable assumptions may take as input only the
isLimit
field, or only theisConicalLimit
fields?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be more precise, for the API I am suggesting, I do not think we would have to assume
HasLimitsOfShape J V
as in #20905.