-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CategoryTheory/Enriched/Ordinary/Limits): Add conical limits for enriched ordinary categories #20904
base: master
Are you sure you want to change the base?
Conversation
PR summary dcb10f71ccImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
This PR/issue depends on: |
open Limits | ||
|
||
variable {J : Type u₁} [Category.{v₁} J] | ||
variable (V : outParam <| Type u') [Category.{v'} V] [MonoidalCategory V] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think V
should be an explicit parameter to IsConicalLimit
. (This is what we have in the rest of the enriched category API, and I believe it should not change.)
Could you also add references to the mathematical literature? and also some minimal API (like constructors which under suitable assumptions may take as input only the isLimit
field, or only the isConicalLimit
fields?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be more precise, for the API I am suggesting, I do not think we would have to assume HasLimitsOfShape J V
as in #20905.
Add the definition
CategoryTheory.Enriched.IsConicalLimit
of conical limits in enriched ordinary catiegories.Co-authored-by: Emily Riehl [email protected]
Co-authored-by: Dagur Asgeirsson [email protected]
depends on: [Merged by Bors] - chore(CategoryTheory/Enriched/Ordinary): create folder to allow API development #20903
API follows in next PR: feat(CategoryTheory/Enriched/Ordinary/Limits/IsConicalLimit): add limit comparison #20905