Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CategoryTheory/Enriched/Ordinary/Limits): Add conical limits for enriched ordinary categories #20904

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Jan 21, 2025

Add the definition CategoryTheory.Enriched.IsConicalLimit of conical limits in enriched ordinary catiegories.

Co-authored-by: Emily Riehl [email protected]
Co-authored-by: Dagur Asgeirsson [email protected]


Open in Gitpod

Copy link

github-actions bot commented Jan 21, 2025

PR summary dcb10f71cc

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Enriched.Ordinary -599
Mathlib.CategoryTheory.Enriched.Ordinary.Basic 599
Mathlib.CategoryTheory.Enriched.Ordinary.Limits.IsConicalLimit (new file) 600

Declarations diff

+ IsConicalLimit
+ eCoyoneda

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joneugster joneugster changed the title Eugster/conical limit 2 feat(CategoryTheory/Enriched/Ordinary/Limits): Add conical limits for enriched ordinary categories Jan 21, 2025
@joneugster joneugster added the t-category-theory Category theory label Jan 21, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jan 21, 2025
@joneugster joneugster marked this pull request as ready for review January 21, 2025 10:44
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jan 21, 2025
@mathlib4-dependent-issues-bot
Copy link
Collaborator

open Limits

variable {J : Type u₁} [Category.{v₁} J]
variable (V : outParam <| Type u') [Category.{v'} V] [MonoidalCategory V]
Copy link
Collaborator

@joelriou joelriou Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think V should be an explicit parameter to IsConicalLimit. (This is what we have in the rest of the enriched category API, and I believe it should not change.)
Could you also add references to the mathematical literature? and also some minimal API (like constructors which under suitable assumptions may take as input only the isLimit field, or only the isConicalLimit fields?)

Copy link
Collaborator

@joelriou joelriou Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more precise, for the API I am suggesting, I do not think we would have to assume HasLimitsOfShape J V as in #20905.

@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes label Jan 21, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 21, 2025
@gio256 gio256 added the infinity-cosmos This PR is associated with Infinity Cosmos project label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes infinity-cosmos This PR is associated with Infinity Cosmos project merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants