Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix the error on existing cache on copy to cache in Artifact.save #2248

Merged
merged 1 commit into from
Dec 3, 2024
+9 −2
Merged

🐛 Fix the error on existing cache on copy to cache in Artifact.save #2248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lamindb/_save.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,17 @@ def copy_or_move_to_cache(
return None
# non-local storage_path further
if local_path != cache_path:
cache_path.parent.mkdir(parents=True, exist_ok=True)
if cache_dir in local_path.parents:
if cache_path.exists():
logger.warning(
f"The cache path {cache_path.as_posix()} already exists, replacing it."
)
if cache_path.is_dir():
shutil.rmtree(cache_path)
else:
cache_path.unlink()
else:
cache_path.parent.mkdir(parents=True, exist_ok=True)
if cache_dir in local_path.parents:
local_path.replace(cache_path)
else:
if is_dir:
Expand Down
Loading