Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix the error on existing cache on copy to cache in Artifact.save #2248

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Dec 3, 2024

Fixes a problem when Artifact.save() is called on a cloud instance but cache with the same path already exists, happens when an Artifact is deleted and then created again.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (4c27162) to head (1d5e1be).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2248      +/-   ##
==========================================
+ Coverage   92.71%   92.90%   +0.19%     
==========================================
  Files          55       55              
  Lines        6947     7162     +215     
==========================================
+ Hits         6441     6654     +213     
- Misses        506      508       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 3, 2024

@github-actions github-actions bot temporarily deployed to pull request December 3, 2024 14:33 Inactive
@Koncopd Koncopd merged commit 9024e43 into main Dec 3, 2024
16 checks passed
@Koncopd Koncopd deleted the fix_existing_cache_on_copy branch December 3, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant