-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-426] Add Dungeon Mode #614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotuuu
added
the
waiting on PR
Waiting on another PR in this repo or in the client repo
label
May 14, 2024
8 tasks
ncontinanza
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tkz00
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autobattler
AFK Gacha Autobattler game
waiting on PR
Waiting on another PR in this repo or in the client repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
To be merged with https://github.com/lambdaclass/champions_of_mirra/pull/459
Motivation
Creates Dungeon Mode for Champions. This PR adds the new campaign as well as the
Closes https://github.com/lambdaclass/champions_of_mirra/issues/426
Summary of changes
How to test it?
You can't test this with the client since it doesn't have the screen for Dungeon campaign. You can create a user and then check his progress in Dungeon:
Grab the level_id of the super_campaign_progress and play the level with
This will advance the super_campaign_progress of the user. Run this and check that the super campaign progress of the "Dungeon" campaign (the one with the id you put in step 2) has changed level id
You can test that locks work by winning the first 10 levels of dungeon mode with a user. You won't be able to win level 11 until you level up your dungeon settlement.