Support multiple supercampaigns #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to process different supercampaigns
ncontinanza
requested review from
jrchatruc,
AminArria,
manucamejo,
tvillegas98,
fkrause98,
martinacantaro,
mgrunwaldt,
AngieDutra,
BertovDev,
saugon,
marco-paulucci,
agustinesco,
mFragaBA,
tkz00,
Nico-Sanchez and
lotuuu
as code owners
…o support-multiple-supercampaigns
lotuuu
previously approved these changes
May 15, 2024
lotuuu
added
the
Waiting on PR
… support-multiple-supercampaigns
lotuuu
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
To be merged with lambdaclass/mirra_backend#614
Caution
When merged, deploy latest changes to server or otherwise campaign will break.
Closes #457
Motivation
We're currently processing all the campaigns that we get from the backend as if they belonged to the same supercampaign. This breaks the changes implemented in lambdaclass/mirra_backend#614, that now sends two different supercampaigns to the client.
Summary of changes
Filter supercampaigns by name.
Now the Overworld scene sends the name of the Main Campaign when the Campaigns button is clicked, so the CampaignsManager knows which supercampaign to display (this is just a patch to allow the backend to merge, a better implementation is being implemented in https://github.com/lambdaclass/champions_of_mirra/pull/444)
How has this been tested?
Start the backend using this branch, and in the client go to campaigns, pick the first campaign and fight a level. Everything should still be working as usual.
Checklist