Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve daily workflow #982

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Improve daily workflow #982

merged 3 commits into from
Dec 20, 2024

Conversation

JulianGCalderon
Copy link
Contributor

  • Increases the max-parallel key, as right now the workflow takes too long
  • Changes some block ranges that had to many transactions, resulting in CI timeout

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Dec 19, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 3.833 ± 0.040 3.794 3.932 1.00
base dict_insert.cairo (AOT) 4.062 ± 0.052 3.964 4.140 1.06 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_insert.cairo (JIT) 3.904 ± 0.042 3.816 3.977 1.00
head dict_insert.cairo (AOT) 4.042 ± 0.030 4.017 4.110 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 4.082 ± 0.055 3.997 4.139 1.00
base dict_snapshot.cairo (AOT) 4.167 ± 0.050 4.120 4.279 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_snapshot.cairo (JIT) 4.091 ± 0.035 4.043 4.156 1.00
head dict_snapshot.cairo (AOT) 4.205 ± 0.026 4.172 4.246 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 4.063 ± 0.068 3.993 4.196 1.00
base factorial_2M.cairo (AOT) 4.228 ± 0.032 4.186 4.282 1.04 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 4.120 ± 0.045 4.052 4.176 1.00
head factorial_2M.cairo (AOT) 4.300 ± 0.019 4.276 4.335 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 3.584 ± 0.020 3.546 3.609 1.00
base fib_2M.cairo (AOT) 3.869 ± 0.032 3.815 3.924 1.08 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 3.646 ± 0.048 3.588 3.755 1.00
head fib_2M.cairo (AOT) 3.832 ± 0.019 3.803 3.861 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 3.881 ± 0.041 3.814 3.950 1.00
base linear_search.cairo (AOT) 3.967 ± 0.092 3.881 4.111 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head linear_search.cairo (JIT) 3.824 ± 0.042 3.773 3.920 1.00
head linear_search.cairo (AOT) 3.958 ± 0.044 3.916 4.051 1.04 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.926 ± 0.058 3.857 4.018 1.00
base logistic_map.cairo (AOT) 3.974 ± 0.035 3.948 4.067 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 3.915 ± 0.026 3.881 3.947 1.00
head logistic_map.cairo (AOT) 4.007 ± 0.029 3.953 4.065 1.02 ± 0.01

Copy link

github-actions bot commented Dec 19, 2024

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 21.162 ± 0.142 20.967 21.442 94.45 ± 1.70
cairo-native (embedded AOT) 4.133 ± 0.035 4.083 4.192 18.45 ± 0.34
cairo-native (embedded JIT using LLVM's ORC Engine) 4.010 ± 0.111 3.868 4.173 17.90 ± 0.58
cairo-native (standalone AOT with -march=native) 0.224 ± 0.004 0.217 0.231 1.00

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.785 ± 0.068 5.711 5.909 17.98 ± 1.16
cairo-native (embedded AOT) 4.259 ± 0.021 4.226 4.285 13.23 ± 0.84
cairo-native (embedded JIT using LLVM's ORC Engine) 4.097 ± 0.032 4.061 4.173 12.73 ± 0.81
cairo-native (standalone AOT with -march=native) 0.322 ± 0.020 0.314 0.380 1.00

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.287 ± 0.077 14.169 14.419 10.58 ± 0.06
cairo-native (embedded AOT) 4.420 ± 0.022 4.383 4.441 3.27 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 4.169 ± 0.032 4.128 4.219 3.09 ± 0.02
cairo-native (standalone AOT with -march=native) 1.350 ± 0.002 1.348 1.355 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.623 ± 0.062 14.533 14.694 186.86 ± 2.36
cairo-native (embedded AOT) 3.992 ± 0.076 3.887 4.110 51.01 ± 1.14
cairo-native (embedded JIT using LLVM's ORC Engine) 3.860 ± 0.073 3.749 3.974 49.32 ± 1.10
cairo-native (standalone AOT with -march=native) 0.078 ± 0.001 0.078 0.084 1.00

Benchmark for program linear_search

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.785 ± 0.056 5.688 5.868 2840.74 ± 100.81
cairo-native (embedded AOT) 4.092 ± 0.065 3.963 4.175 2009.01 ± 75.59
cairo-native (embedded JIT using LLVM's ORC Engine) 3.909 ± 0.070 3.837 4.016 1919.47 ± 73.88
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.003 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.776 ± 0.045 5.705 5.859 23.84 ± 0.19
cairo-native (embedded AOT) 4.106 ± 0.028 4.056 4.152 16.94 ± 0.12
cairo-native (embedded JIT using LLVM's ORC Engine) 3.962 ± 0.055 3.894 4.062 16.35 ± 0.23
cairo-native (standalone AOT with -march=native) 0.242 ± 0.000 0.242 0.243 1.00

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.76%. Comparing base (f53c947) to head (bef9ba2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #982   +/-   ##
=======================================
  Coverage   80.76%   80.76%           
=======================================
  Files         107      107           
  Lines       29256    29256           
=======================================
  Hits        23628    23628           
  Misses       5628     5628           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabrielbosio gabrielbosio added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit e41f7b1 Dec 20, 2024
32 checks passed
@gabrielbosio gabrielbosio deleted the improve-daily branch December 20, 2024 20:50
@JulianGCalderon JulianGCalderon mentioned this pull request Dec 26, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants