Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compare block list #987

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix compare block list #987

wants to merge 1 commit into from

Conversation

JulianGCalderon
Copy link
Contributor

We forgot to update the compare block list when we merged PR #982

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.76%. Comparing base (e41f7b1) to head (7336e47).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #987   +/-   ##
=======================================
  Coverage   80.76%   80.76%           
=======================================
  Files         107      107           
  Lines       29256    29256           
=======================================
  Hits        23628    23628           
  Misses       5628     5628           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 3.815 ± 0.010 3.799 3.830 1.00
base dict_insert.cairo (AOT) 3.969 ± 0.022 3.927 4.000 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_insert.cairo (JIT) 3.818 ± 0.033 3.768 3.862 1.00
head dict_insert.cairo (AOT) 3.942 ± 0.021 3.906 3.971 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 4.050 ± 0.022 4.024 4.091 1.00
base dict_snapshot.cairo (AOT) 4.158 ± 0.020 4.134 4.200 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_snapshot.cairo (JIT) 3.988 ± 0.022 3.951 4.020 1.00
head dict_snapshot.cairo (AOT) 4.117 ± 0.029 4.079 4.179 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 4.024 ± 0.019 3.999 4.064 1.00
base factorial_2M.cairo (AOT) 4.222 ± 0.026 4.190 4.267 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 4.042 ± 0.050 3.965 4.127 1.00
head factorial_2M.cairo (AOT) 4.251 ± 0.031 4.208 4.290 1.05 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 3.594 ± 0.022 3.554 3.634 1.00
base fib_2M.cairo (AOT) 3.792 ± 0.019 3.755 3.817 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 3.558 ± 0.015 3.536 3.579 1.00
head fib_2M.cairo (AOT) 3.763 ± 0.009 3.749 3.779 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 3.775 ± 0.029 3.723 3.825 1.00
base linear_search.cairo (AOT) 3.911 ± 0.031 3.863 3.971 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head linear_search.cairo (JIT) 3.747 ± 0.019 3.717 3.782 1.00
head linear_search.cairo (AOT) 3.846 ± 0.023 3.816 3.890 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.885 ± 0.026 3.855 3.938 1.00
base logistic_map.cairo (AOT) 3.945 ± 0.024 3.903 3.982 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 3.837 ± 0.012 3.823 3.860 1.00
head logistic_map.cairo (AOT) 3.912 ± 0.016 3.887 3.941 1.02 ± 0.01

Copy link

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 20.453 ± 0.120 20.324 20.748 97.15 ± 2.32
cairo-native (embedded AOT) 3.963 ± 0.022 3.930 4.008 18.82 ± 0.45
cairo-native (embedded JIT using LLVM's ORC Engine) 3.795 ± 0.020 3.763 3.830 18.02 ± 0.43
cairo-native (standalone AOT with -march=native) 0.211 ± 0.005 0.203 0.216 1.00

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.718 ± 0.030 5.666 5.772 17.97 ± 0.27
cairo-native (embedded AOT) 4.148 ± 0.030 4.098 4.201 13.04 ± 0.20
cairo-native (embedded JIT using LLVM's ORC Engine) 4.043 ± 0.020 4.020 4.077 12.71 ± 0.19
cairo-native (standalone AOT with -march=native) 0.318 ± 0.004 0.315 0.328 1.00

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.003 ± 0.086 13.879 14.174 10.38 ± 0.06
cairo-native (embedded AOT) 4.284 ± 0.031 4.252 4.356 3.17 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 4.093 ± 0.022 4.056 4.122 3.03 ± 0.02
cairo-native (standalone AOT with -march=native) 1.350 ± 0.000 1.349 1.350 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.343 ± 0.043 14.263 14.404 183.67 ± 0.71
cairo-native (embedded AOT) 3.876 ± 0.030 3.834 3.931 49.64 ± 0.41
cairo-native (embedded JIT using LLVM's ORC Engine) 3.678 ± 0.024 3.643 3.721 47.10 ± 0.32
cairo-native (standalone AOT with -march=native) 0.078 ± 0.000 0.078 0.079 1.00

Benchmark for program linear_search

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.718 ± 0.016 5.688 5.747 2877.53 ± 56.27
cairo-native (embedded AOT) 3.897 ± 0.032 3.843 3.952 1960.99 ± 41.16
cairo-native (embedded JIT using LLVM's ORC Engine) 3.799 ± 0.030 3.756 3.838 1911.41 ± 39.87
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.002 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.622 ± 0.044 5.571 5.707 23.18 ± 0.18
cairo-native (embedded AOT) 3.952 ± 0.027 3.915 3.989 16.30 ± 0.11
cairo-native (embedded JIT using LLVM's ORC Engine) 3.877 ± 0.069 3.811 4.062 15.99 ± 0.29
cairo-native (standalone AOT with -march=native) 0.243 ± 0.000 0.242 0.243 1.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants