Added segment arena cairo1 runner validation. #1721
Conversation
orizi
requested review from
igaray,
Oppen,
fmoletta,
juanbono and
pefontana
as code owners
orizi
force-pushed
the
feat/segment-arena-cairo1-validation
branch
2 times, most recently
from
8aefb47 to
116e7cf
Compare
There was a problem hiding this comment.
The cairo programs returning non-squashed dicts are mainly used to test output serialization, and correspond to issues raised by users of the crate. I would prefer to keep them like this to ensure that the same issues don't pop up in the future.
(Relevant issue)
|
The serialization of such dictionaries should not be supported - it is never a valid run. |
|
Specifically - the related issue should have the same effect for checking on SquashedDict - i simply add that a regular |
| @@ -356,97 +362,112 @@ fn create_entry_code( | |||
| // The builtins in the formatting expected by the runner. | |||
| let (builtins, builtin_offset) = | |||
| get_function_builtins(&signature.param_types, copy_to_output_builtin); | |||
| let mut ctx = casm! {}; | |||
| let mut ctx = CasmBuilder::default(); | |||
There was a problem hiding this comment.
@orizi Can you add some documentation here?
Specially in the casm_extend! cases?
There was a problem hiding this comment.
do note this is exactly the same code as before - only where the code may somewhat be understandable by variable name.
add some additional doc.
There was a problem hiding this comment.
Since this Dict return programs are still running without proof_mode, can we made some test for the old version of the cairo program that runs OK without proof_mode and fails when proof_mode?
There was a problem hiding this comment.
it shouldn't work at any version - it is a legal cairo function - but not a sensible run.
even when not running in proof mode i would not expect to be able to run unprovable programs, unless these are actually a test.
| Ok((ctx, builtins)) | ||
| let result = ctx.build(["FUNCTION"]); | ||
| let [call_inst] = result.branches[0].1.as_slice() else { | ||
| panic!("Expected a single relocation"); |
There was a problem hiding this comment.
Can we avoid the panics here? If it is to much work just create an issue and we will handle it
There was a problem hiding this comment.
this cannot ever actually panic - given that the builder code is correct (it will either always crash if we've written bad code here) or never crash (if the code here is fine - which it is)
orizi
force-pushed
the
feat/segment-arena-cairo1-validation
branch
from
672d638 to
9699235
Compare
orizi
force-pushed
the
feat/segment-arena-cairo1-validation
branch
from
9699235 to
a79d32f
Compare
orizi
force-pushed
the
feat/segment-arena-cairo1-validation
branch
from
d4c96d2 to
dfe52bc
Compare
Added Cairo1 run minibootloader for segment arena validation.
Description
Using the cairo1 repo casm builder for easier CASM writing for writing the validation.
Added finalization of dicts in cairo1 hint processor.
Used both to add the validation in the runner.
Updated the tests - as some of the tests returned a Dictionary from main - which isn't sound for proving code (as no squash occured).
Checklist