Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for cairo 1 programs returning Felt252Dict #1731

Closed
fmoletta opened this issue Apr 24, 2024 · 2 comments
Closed

Add tests for cairo 1 programs returning Felt252Dict #1731

fmoletta opened this issue Apr 24, 2024 · 2 comments
Assignees
@FrancoGiachetta
Labels
tests Implementation of tests

Comments

@fmoletta
Copy link
Contributor

PR #1721 modified the test programs that returned Felt252Dict so that they now return their squashed version. While the PR makes sure that these programs fail in proof_mode (as unsquashed dicts cannot be proven), they can still be ran without proof_mode, and therefore we should have tests that make sure that they can be serialized correctly.
@fmoletta fmoletta added the tests Implementation of tests label Apr 24, 2024
@elielnfinic
Copy link

Can I work on this?

@pefontana
Copy link
Collaborator

done #1797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrancoGiachetta FrancoGiachetta

Labels
tests Implementation of tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@elielnfinic @pefontana @fmoletta @FrancoGiachetta