Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI | Fix virt-v2v customize script guest tests #1300

Merged
merged 2 commits into from
Jan 13, 2025
+2 −1
Merged

CI | Fix virt-v2v customize script guest tests #1300

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
848f1c8
CI | Fix virt-v2v customize script guest tests
mnecas Jan 13, 2025
e37f02c
Merge branch 'main' into fix_pr_test2
mnecas Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion virt-v2v/pkg/customize/scripts/rhel/run/test-network_config_util.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ test_dir() {
export NETWORK_CONNECTIONS_DIR="$TEST_DIR/etc/NetworkManager/system-connections"
export UDEV_RULES_FILE="$TEST_DIR/etc/udev/rules.d/70-persistent-net.rules"
export SYSTEMD_NETWORK_DIR="$TEST_DIR/run/systemd/network"
export NETPLAN_DIR="$TEST_DIR/etc/netplan"
export NETPLAN_DIR="$TEST_DIR/"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect path


export IFQUERY_CMD="
podman run
Expand Down Expand Up @@ -70,6 +70,7 @@ test_dirs() {
}

expected_to_pass_dirs() {
local FAIL_IS_FATAL=true PASS_IS_FATAL=false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it fails, we did not show output

test_dirs "$@"
}

Expand Down
Loading