CI | Fix virt-v2v customize script guest tests #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
==========================================
- Coverage 15.50% 15.45% -0.05%
==========================================
Files 112 112
Lines 23377 23377
==========================================
- Hits 3624 3613 -11
- Misses 19466 19479 +13
+ Partials 287 285 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Martin Necas <[email protected]>
mnecas
commented
Jan 13, 2025
| @@ -70,6 +70,7 @@ test_dirs() { | |||
| } | |||
|
|
|||
| expected_to_pass_dirs() { | |||
| local FAIL_IS_FATAL=true PASS_IS_FATAL=false | |||
There was a problem hiding this comment.
if it fails, we did not show output
mnecas
commented
Jan 13, 2025
| @@ -18,7 +18,7 @@ test_dir() { | |||
| export NETWORK_CONNECTIONS_DIR="$TEST_DIR/etc/NetworkManager/system-connections" | |||
| export UDEV_RULES_FILE="$TEST_DIR/etc/udev/rules.d/70-persistent-net.rules" | |||
| export SYSTEMD_NETWORK_DIR="$TEST_DIR/run/systemd/network" | |||
| export NETPLAN_DIR="$TEST_DIR/etc/netplan" | |||
| export NETPLAN_DIR="$TEST_DIR/" | |||
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix virt-v2v customize script guest tests ci