Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unregister-member deletes secret & has needed permissions #99

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

MatousJobanek
Copy link
Contributor

KUBESAW-247
unregister-member should delete also the ToolchainCluster secret.
the role defines the needed permissions

- "toolchainclusters"
verbs:
- "get"
- "list"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the list is not needed, but it's technically the same as get so it's fine to keep it there

Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MatousJobanek MatousJobanek merged commit 3f3bb70 into kubesaw:master Jan 10, 2025
6 of 7 checks passed
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base (ec701fa) to head (325af8b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cmd/adm/unregister_member.go 64.70% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   67.83%   67.80%   -0.03%     
==========================================
  Files          44       44              
  Lines        3264     3280      +16     
==========================================
+ Hits         2214     2224      +10     
- Misses        853      857       +4     
- Partials      197      199       +2     
Files with missing lines Coverage Δ
pkg/cmd/adm/unregister_member.go 56.66% <64.70%> (+2.12%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants