Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a role for unregister-member command and delete the referenced secret when unregistering the member #98

Closed

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Jan 10, 2025

This is a simple PR to also delete the secret together with the ToolchainCluster resource when unregistering the member.

@MatousJobanek
Copy link
Contributor

closing in favor of #99 as it take care of the case when the secret is already removed

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.71%. Comparing base (ec701fa) to head (21890b8).

Files with missing lines Patch % Lines
pkg/cmd/adm/unregister_member.go 14.28% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   67.83%   67.71%   -0.12%     
==========================================
  Files          44       44              
  Lines        3264     3271       +7     
==========================================
+ Hits         2214     2215       +1     
- Misses        853      857       +4     
- Partials      197      199       +2     
Files with missing lines Coverage Δ
pkg/cmd/adm/unregister_member.go 49.01% <14.28%> (-5.53%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants