Wire server run options to flags. #1560
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
This issue is currently awaiting triage. If metrics-server contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
The motivating use case for these options is to configure graceful shutdown so that kube-aggregators using endpoint-based apiservice resolution (--enable-aggregator-routing) have time to stop routing to a given metrics-server instance before it stops.
benluddy
force-pushed
the
server-run-options
branch
from
ea54768
to
a4fc038
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, dgrisonnet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| Version format could only be major.minor, for example: '--emulated-version=wardle=1.2,kube=1.31'. Options are: | ||
| kube=1.31..1.31 (default=1.31)If the component is not specified, defaults to "kube" | ||
| --external-hostname string The hostname to use when generating externalized URLs for this master (e.g. Swagger API Docs or OpenID Discovery). | ||
| --feature-gates colonSeparatedMultimapStringString Comma-separated list of component:key=value pairs that describe feature gates for alpha/experimental features of different components. |
There was a problem hiding this comment.
We don't support most of the feature flags listed here.
There was a problem hiding this comment.
Are you suggesting that we should override the flag to change the description to only include the feature gates that metrics-server's code uses?
There was a problem hiding this comment.
From user perspective yes, we should not expose nor document flags that don't work or are not supported in our documentation.
There was a problem hiding this comment.
That's fair, I'll try to figure out how we can have a curated list that is kept in sync with k/k
What this PR does / why we need it:
Exposes the server run options set via cli flags.
The motivating use case for these options is to configure graceful shutdown so that kube-aggregators using endpoint-based apiservice resolution (--enable-aggregator-routing) have time to stop routing to a given metrics-server instance before it stops.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #