OCPBUGS-39133: Add graceful shutdown flags #34

dgrisonnet · 2024-09-09T17:41:42Z

What this PR does / why we need it:

This PR brings kubernetes-sigs#1560 which is required by https://issues.redhat.com/browse/OCPBUGS-39133

Bumps the gomod-dependencies group with 6 updates: | Package | From | To | | --- | --- | --- | | [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) | `2.14.0` | `2.15.0` | | [github.com/onsi/gomega](https://github.com/onsi/gomega) | `1.30.0` | `1.31.1` | | [k8s.io/api](https://github.com/kubernetes/api) | `0.29.0` | `0.29.1` | | [k8s.io/apiserver](https://github.com/kubernetes/apiserver) | `0.29.0` | `0.29.1` | | [k8s.io/klog/v2](https://github.com/kubernetes/klog) | `2.120.0` | `2.120.1` | | [k8s.io/metrics](https://github.com/kubernetes/metrics) | `0.29.0` | `0.29.1` | Updates `github.com/onsi/ginkgo/v2` from 2.14.0 to 2.15.0 - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.14.0...v2.15.0) Updates `github.com/onsi/gomega` from 1.30.0 to 1.31.1 - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.30.0...v1.31.1) Updates `k8s.io/api` from 0.29.0 to 0.29.1 - [Commits](kubernetes/api@v0.29.0...v0.29.1) Updates `k8s.io/apiserver` from 0.29.0 to 0.29.1 - [Commits](kubernetes/apiserver@v0.29.0...v0.29.1) Updates `k8s.io/klog/v2` from 2.120.0 to 2.120.1 - [Release notes](https://github.com/kubernetes/klog/releases) - [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md) - [Commits](kubernetes/klog@v2.120.0...v2.120.1) Updates `k8s.io/metrics` from 0.29.0 to 0.29.1 - [Commits](kubernetes/metrics@v0.29.0...v0.29.1) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod-dependencies - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod-dependencies - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod-dependencies - dependency-name: k8s.io/apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod-dependencies - dependency-name: k8s.io/klog/v2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod-dependencies - dependency-name: k8s.io/metrics dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>

…ot/go_modules/gomod-dependencies-125bb43b82 Bump the gomod-dependencies group with 6 updates

Signed-off-by: Steve Hipwell <[email protected]>

…rt-v3-12-0 feat(chart): Released v3.12.0 (v0.7.0)

Signed-off-by: Steve Hipwell <[email protected]>

…elease fix(chart): Fixed incorrect changelog version lookup

Bumps [action-stars/install-tool-from-github-release](https://github.com/action-stars/install-tool-from-github-release) from 0.2.1 to 0.2.2. - [Release notes](https://github.com/action-stars/install-tool-from-github-release/releases) - [Changelog](https://github.com/action-stars/install-tool-from-github-release/blob/main/CHANGELOG.md) - [Commits](action-stars/install-tool-from-github-release@b21a018...9019d0a) --- updated-dependencies: - dependency-name: action-stars/install-tool-from-github-release dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.8.0 to 1.9.0. - [Release notes](https://github.com/helm/kind-action/releases) - [Commits](helm/kind-action@dda0770...99576bf) --- updated-dependencies: - dependency-name: helm/kind-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…ot/github_actions/helm/kind-action-1.9.0 Bump helm/kind-action from 1.8.0 to 1.9.0

…kind0.22.0 Update kind to use v0.22.0 version to support new kubernetes version

Bumps [mikefarah/yq](https://github.com/mikefarah/yq) from 4.40.5 to 4.42.1. - [Release notes](https://github.com/mikefarah/yq/releases) - [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt) - [Commits](mikefarah/yq@dd64899...9adde1a) --- updated-dependencies: - dependency-name: mikefarah/yq dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…ot/github_actions/mikefarah/yq-4.42.1 Bump mikefarah/yq from 4.40.5 to 4.42.1

With the 1.27 Kubernetes upgrade, a new GetSingularName method needed to be implemented by the metrics rest.Storage. While doing it, we set a value for the singular name of the resources when it used to be empty. Due to that, the kube-apiserver stop guessing the resource name based on its Kind, which broken kubectl get PodMetrics/NodeMetrics. To fix that, we need to blank out the singular name of the resources, otherwise we will be stuck with the following commands: - kubectl get pod.metric - kubectl get node.metric Instead of the more commonly used: - kubectl get PodMetrics - kubectl get NodeMetrics Signed-off-by: Damien Grisonnet <[email protected]>

…name Fix kubectl get PodMetrics/NodeMetrics

…rlink Improve: Add hyperlink to Prometheus in README

…-alerts Improve README - Highlight content with distinctive styling

Bumps [mindsers/changelog-reader-action](https://github.com/mindsers/changelog-reader-action) from 2.2.2 to 2.2.3. - [Release notes](https://github.com/mindsers/changelog-reader-action/releases) - [Changelog](https://github.com/mindsers/changelog-reader-action/blob/master/CHANGELOG.md) - [Commits](mindsers/changelog-reader-action@b97ce03...32aa5b4) --- updated-dependencies: - dependency-name: mindsers/changelog-reader-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@de2c0eb...d99959e) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

…ot/github_actions/mindsers/changelog-reader-action-2.2.3 Bump mindsers/changelog-reader-action from 2.2.2 to 2.2.3

…ot/github_actions/action-stars/install-tool-from-github-release-0.2.2 Bump action-stars/install-tool-from-github-release from 0.2.1 to 0.2.2

…ot/github_actions/softprops/action-gh-release-2 Bump softprops/action-gh-release from 1 to 2

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.0.0 to 5.1.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@0a5c615...82c7e63) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: Steve Hipwell <[email protected]>

…v0.7.1 chore(chart): Updated Helm chart for v0.7.1

Co-authored-by: Marek Siarkowicz <[email protected]>

Remove double negative in README.md

Wire server run options to flags.

…-shutdown

Signed-off-by: Damien Grisonnet <[email protected]>

openshift-ci · 2024-09-09T21:58:55Z

@dgrisonnet: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

simonpasquier · 2024-09-10T07:02:20Z

/retitle OCPBUGS-39133: Add graceful shutdown flags

openshift-ci-robot · 2024-09-10T07:02:30Z

@dgrisonnet: This pull request references Jira Issue OCPBUGS-39133, which is invalid:

expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:

This PR brings kubernetes-sigs#1560 which is required by https://issues.redhat.com/browse/OCPBUGS-39133

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

simonpasquier · 2024-09-10T07:05:02Z

/jira refresh

openshift-ci-robot · 2024-09-10T07:05:06Z

@simonpasquier: This pull request references Jira Issue OCPBUGS-39133, which is invalid:

expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

simonpasquier · 2024-09-10T07:05:58Z

/jira refresh

openshift-ci-robot · 2024-09-10T07:06:05Z

@simonpasquier: This pull request references Jira Issue OCPBUGS-39133, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

simonpasquier · 2024-09-10T07:06:32Z

/approve
/lgtm

openshift-ci · 2024-09-10T07:07:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-09-10T07:10:50Z

@dgrisonnet: Jira Issue OCPBUGS-39133: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/cluster-monitoring-operator#2460 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-39133 has not been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:

This PR brings kubernetes-sigs#1560 which is required by https://issues.redhat.com/browse/OCPBUGS-39133

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

simonpasquier · 2024-09-10T07:23:58Z

/jira backport release-4.17

openshift-ci-robot · 2024-09-10T07:24:08Z

@simonpasquier: The following backport issues have been created:

OCPBUGS-41580 for branch release-4.17

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.17

In response to this:

/jira backport release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2024-09-10T07:24:51Z

@openshift-ci-robot: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked.

Error message

status code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#list-pull-requests-files","status":"406"}

In response to this:

@simonpasquier: The following backport issues have been created:

OCPBUGS-41580 for branch release-4.17

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.17

In response to this:

/jira backport release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2024-09-10T10:13:53Z

[ART PR BUILD NOTIFIER]

Distgit: ose-kube-metrics-server
This PR has been included in build ose-kube-metrics-server-container-v4.18.0-202409100942.p0.g962ccca.assembly.stream.el9.
All builds following this will include this PR.

dependabot bot and others added 30 commits January 22, 2024 13:01

Merge pull request kubernetes-sigs#1411 from kubernetes-sigs/dependab…

1b01024

…ot/go_modules/gomod-dependencies-125bb43b82 Bump the gomod-dependencies group with 6 updates

feat(chart): Released v3.12.0 (v0.7.0)

fd7517d

Signed-off-by: Steve Hipwell <[email protected]>

Merge pull request kubernetes-sigs#1414 from stevehipwell/release-cha…

605bc86

…rt-v3-12-0 feat(chart): Released v3.12.0 (v0.7.0)

fix(chart): Fixed incorrect changelog version lookup

bc7e702

Signed-off-by: Steve Hipwell <[email protected]>

Merge pull request kubernetes-sigs#1417 from stevehipwell/fix-chart-r…

1cd2b2d

…elease fix(chart): Fixed incorrect changelog version lookup

Update kind to use v0.22.0 version to support new kubernetes version

c43bc64

Merge pull request kubernetes-sigs#1420 from kubernetes-sigs/dependab…

e761e04

…ot/github_actions/helm/kind-action-1.9.0 Bump helm/kind-action from 1.8.0 to 1.9.0

Merge pull request kubernetes-sigs#1423 from yangjunmyfm192085/update…

1185328

…kind0.22.0 Update kind to use v0.22.0 version to support new kubernetes version

Merge pull request kubernetes-sigs#1430 from kubernetes-sigs/dependab…

a6a0ea3

…ot/github_actions/mikefarah/yq-4.42.1 Bump mikefarah/yq from 4.40.5 to 4.42.1

Update README

3ce5101

Add Prometheus hyperlink

7c8daea

Merge pull request kubernetes-sigs#1436 from dgrisonnet/fix-singular-…

7d9dfa8

…name Fix kubectl get PodMetrics/NodeMetrics

Merge pull request kubernetes-sigs#1435 from tuladhar/prometheus-hype…

c74a862

…rlink Improve: Add hyperlink to Prometheus in README

Merge pull request kubernetes-sigs#1434 from tuladhar/emphasize-using…

02081eb

…-alerts Improve README - Highlight content with distinctive styling

Merge pull request kubernetes-sigs#1439 from kubernetes-sigs/dependab…

474a0e8

…ot/github_actions/mindsers/changelog-reader-action-2.2.3 Bump mindsers/changelog-reader-action from 2.2.2 to 2.2.3

Merge pull request kubernetes-sigs#1419 from kubernetes-sigs/dependab…

1b6948f

…ot/github_actions/action-stars/install-tool-from-github-release-0.2.2 Bump action-stars/install-tool-from-github-release from 0.2.1 to 0.2.2

Merge pull request kubernetes-sigs#1440 from kubernetes-sigs/dependab…

af43f40

…ot/github_actions/softprops/action-gh-release-2 Bump softprops/action-gh-release from 1 to 2

chore(chart): Updated Helm chart for v0.7.1

5694dce

Signed-off-by: Steve Hipwell <[email protected]>

Merge pull request kubernetes-sigs#1461 from stevehipwell/helm-chart-…

525eb66

…v0.7.1 chore(chart): Updated Helm chart for v0.7.1

Remove double negative in README.md

2f4a8b2

Update README.md

3d6ecce

Co-authored-by: Marek Siarkowicz <[email protected]>

Merge pull request kubernetes-sigs#1462 from Georift/patch-2

7e71fc5

Remove double negative in README.md

k8s-ci-robot and others added 2 commits September 6, 2024 16:35

Merge pull request kubernetes-sigs#1560 from benluddy/server-run-options

aacd5cb

Wire server run options to flags.

Merge commit 'aacd5cbf09aa7d6a83e2444d1729f846b2e8439e' into graceful…

6c7026f

…-shutdown

openshift-ci bot requested review from rexagod and simonpasquier September 9, 2024 17:41

vendor: update

07cb1ae

Signed-off-by: Damien Grisonnet <[email protected]>

openshift-ci bot changed the title ~~Add graceful shutdown flags~~ OCPBUGS-39133: Add graceful shutdown flags Sep 10, 2024

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 10, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 10, 2024

openshift-ci bot requested a review from wangke19 September 10, 2024 07:06

openshift-ci bot assigned simonpasquier Sep 10, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024

openshift-merge-bot bot merged commit 962ccca into openshift:master Sep 10, 2024
7 checks passed

openshift-ci-robot mentioned this pull request Sep 10, 2024

OCPBUGS-39133: Configure graceful shutdown for metrics-server openshift/cluster-monitoring-operator#2460

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-39133: Add graceful shutdown flags #34

OCPBUGS-39133: Add graceful shutdown flags #34

dgrisonnet commented Sep 9, 2024

openshift-ci bot commented Sep 9, 2024

simonpasquier commented Sep 10, 2024

openshift-ci-robot commented Sep 10, 2024

simonpasquier commented Sep 10, 2024

openshift-ci-robot commented Sep 10, 2024

simonpasquier commented Sep 10, 2024

openshift-ci-robot commented Sep 10, 2024

simonpasquier commented Sep 10, 2024

openshift-ci bot commented Sep 10, 2024

openshift-ci-robot commented Sep 10, 2024

simonpasquier commented Sep 10, 2024

openshift-ci-robot commented Sep 10, 2024

openshift-cherrypick-robot commented Sep 10, 2024

openshift-bot commented Sep 10, 2024

OCPBUGS-39133: Add graceful shutdown flags #34

OCPBUGS-39133: Add graceful shutdown flags #34

Conversation

dgrisonnet commented Sep 9, 2024

openshift-ci bot commented Sep 9, 2024

simonpasquier commented Sep 10, 2024

openshift-ci-robot commented Sep 10, 2024

simonpasquier commented Sep 10, 2024

openshift-ci-robot commented Sep 10, 2024

simonpasquier commented Sep 10, 2024

openshift-ci-robot commented Sep 10, 2024

simonpasquier commented Sep 10, 2024

openshift-ci bot commented Sep 10, 2024

openshift-ci-robot commented Sep 10, 2024

simonpasquier commented Sep 10, 2024

openshift-ci-robot commented Sep 10, 2024

openshift-cherrypick-robot commented Sep 10, 2024

openshift-bot commented Sep 10, 2024