Always remove deleted submissions entirely instead of merely marking them as deleted #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and delete submissions outright
jnm
force-pushed
the
stop-querying-deleted-at
branch
from
f6145eb to
9e2a78a
Compare
jnm
changed the title
# Conflicts: # onadata/apps/logger/management/commands/sync_deleted_instances_fix.py # onadata/apps/logger/models/instance.py # onadata/apps/logger/tests/test_command_syncd_deleted_instances_fix.py # onadata/apps/main/tests/test_form_api_delete.py # onadata/apps/main/views.py # onadata/apps/survey_report/views.py # onadata/apps/viewer/management/commands/update_delete_from_mongo.py # onadata/apps/viewer/models/parsed_instance.py # onadata/apps/viewer/pandas_mongo_bridge.py # onadata/libs/utils/export_tools.py
|
@noliveleger thanks for making this work with KoBoCAT 2.0 |
This was referenced Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deleting submissions through the legacy view (but not via the API), a special marker was applied to the "deleted" submissions instead of removing them outright. This meant that every query to retrieve submitted data needed to filter out submissions having this marker. We now always remove submissions outright when deleting and therefore no longer need this extra filter, which caused high database overhead.
Related issues
Closes #696
Related to kobotoolbox/kpi#3287