Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_deleted_at incorrectly set to the date the server last started, not the actual deletion time #472

Closed
jnm opened this issue Jul 23, 2018 · 1 comment
Assignees
Labels

Comments

@jnm
Copy link
Member

jnm commented Jul 23, 2018

very common python mistake:

def set_deleted(self, deleted_at=timezone.now()):
self.deleted_at = deleted_at
self.save()
# force submission count re-calculation
self.xform.submission_count(force_update=True)
self.parsed_instance.save()

@jnm jnm added the bug label Jul 23, 2018
@jnm jnm self-assigned this Jul 23, 2018
@jnm jnm changed the title _deleted_at set to the date the server last started _deleted_at incorrectly set to the date the server last started, not the actual deletion time Jul 23, 2018
@jnm
Copy link
Member Author

jnm commented Aug 5, 2021

deleted_at has been fully removed as of #732 and #744.

@jnm jnm closed this as completed Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant