-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[performance/real-traffic-test] Enable AllowHTTPFullDuplexFeature #15654
[performance/real-traffic-test] Enable AllowHTTPFullDuplexFeature #15654
Conversation
/test performance-tests |
passed this time, let's try again /test performance-tests |
The only issue I see is:
|
/lgtm /hold if you need more tests. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maschmid, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
let's do one more round for the real-traffic-test /test performance-tests |
I can see in the history the scale-from-zero failing with 404s quite often , https://prow.knative.dev/job-history/gs/knative-prow/logs/performance-tests_serving_main_periodic anyway, let's merge this one first, as the real-traffic-test is unrelated. I'll take a look at the scale-from-zero 404s later. /unhold |
Proposed Changes
WithConfigAnnotations was added to
sos
when the firstactivatorInPath
was true, so it affected all further svcs, not just the current one.