Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[performance/real-traffic-test] Enable AllowHTTPFullDuplexFeature #15654

Merged

Conversation

maschmid
Copy link
Contributor

Proposed Changes

WithConfigAnnotations was added to sos when the first activatorInPath was true, so it affected all further svcs, not just the current one.

  • fixes TargetBurstCapacityKey annotation to be set only when activatorInPath is true
  • enables AllowHTTPFullDuplexFeature to see if it helps with the random EOF errors
  • rounds SLA 2, rate calculation to nearest integer

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 16, 2024
@knative-prow knative-prow bot requested review from izabelacg and ReToCode December 16, 2024 17:36
@maschmid
Copy link
Contributor Author

/test performance-tests

@maschmid
Copy link
Contributor Author

https://storage.googleapis.com/knative-prow/pr-logs/pull/knative_serving/15654/performance-tests_serving_main/1868717036239065088/artifacts/real-traffic-test.log

2024/12/16 18:18:06 SLA 1 passed. No errors occurred
2024/12/16 18:18:06 SLA 2 passed. vegeta rate is 2000.000000

passed this time, let's try again

/test performance-tests

@skonto
Copy link
Contributor

skonto commented Dec 17, 2024

The only issue I see is:

Status Codes  [code:count]                      
Error Set:
2024/12/16 21:33:38 SLA 3 failed. total requests is 0, expected total requests is 1
job.batch "scale-from-zero-1" deleted
service.serving.knative.dev "perftest-scalefromzero-00-ihnhfssl" deleted

@skonto skonto self-assigned this Dec 17, 2024
@skonto
Copy link
Contributor

skonto commented Dec 17, 2024

/lgtm
/approve

/hold if you need more tests.

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 17, 2024
Copy link

knative-prow bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@maschmid
Copy link
Contributor Author

let's do one more round for the real-traffic-test

/test performance-tests

@maschmid
Copy link
Contributor Author

I can see in the history the scale-from-zero failing with 404s quite often , https://prow.knative.dev/job-history/gs/knative-prow/logs/performance-tests_serving_main_periodic

anyway, let's merge this one first, as the real-traffic-test is unrelated. I'll take a look at the scale-from-zero 404s later.

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@knative-prow knative-prow bot merged commit d1e308e into knative:main Dec 17, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants