[test/performance] round computed rate in real-traffic-test

[maschmid]

real-traffic-test benchmark SLA 2 fails frequently just because the computed rate is not exactly the expected value , e.g. https://prow.knative.dev/view/gs/knative-prow/logs/performance-tests_serving_main_periodic/1862287597506662400

SLA 2 failed. vegeta rate is 2000.006921, expected Rate is 2000.000000

Let's do the same here as we already to in https://github.com/knative/serving/blob/main/test/performance/benchmarks/rollout-probe/main.go#L234 , and add tolerance to the rate comparison to fit within the nearest integer.

• round computed Rate on real-traffic-test benchmark

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.53%. Comparing base (5717d19) to head (8eed01e).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15641   +/-   ##
=======================================
  Coverage   83.53%   83.53%           
=======================================
  Files         219      219           
  Lines       17427    17427           
=======================================
  Hits        14558    14558           
+ Misses       2498     2496    -2     
- Partials      371      373    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[skonto]

/test ?

[knative-prow]

@skonto: The following commands are available to trigger required jobs:

/test build-tests

/test contour-latest

/test contour-tls

/test gateway-api-latest

/test istio-latest-no-mesh

/test istio-latest-no-mesh-tls

/test kourier-stable

/test kourier-stable-tls

/test unit-tests

/test upgrade-tests

The following commands are available to trigger optional jobs:

/test gateway-api-latest-and-contour

/test https

/test istio-latest-mesh

/test istio-latest-mesh-short

/test istio-latest-mesh-tls

/test performance-tests

Use /test all to run the following jobs that were automatically triggered:

build-tests_serving_main

istio-latest-no-mesh-tls_serving_main

istio-latest-no-mesh_serving_main

unit-tests_serving_main

upgrade-tests_serving_main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[skonto]

/test performance-tests

[skonto]

Din't pass the first SLA. :(

2024/12/09 08:57:07 Starting vegeta attack for with 2000 RPS for duration: 5m0s
2024/12/09 08:57:23 error occurred calling target. Err: unexpected EOF, url: http://perftest-17-hzoafmoh.default.svc.cluster.local?sleep=4793, method: POST
Requests      [total, rate, throughput]         599996, 1999.86, 1999.83
Duration      [total, attack, wait]             5m0s, 5m0s, 5.391ms
Latencies     [min, mean, 50, 90, 95, 99, max]  3.354ms, 7.654ms, 5.401ms, 9.567ms, 14.572ms, 34.819ms, 1.012s
Bytes In      [total, mean]                     7341775345, 12236.37
Bytes Out     [total, mean]                     17131476748, 28552.65
Success       [ratio]                           100.00%
2024/12/09 09:02:07 Cleaning up all created services
Status Codes  [code:count]                      0:1  200:599995  
Error Set:
unexpected EOF
2024/12/09 09:02:10 Shutting down InfluxReporter
2024/12/09 09:02:10 SLA 1 failed. Errors occurred: 1
job.batch "real-traffic-test" deleted

[skonto]

/test performance-tests

[skonto]

/lgtm
/hold for the tests

[skonto]

/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[skonto]

@maschmid hi, this still fails:

2024/12/13 09:17:27 Cleaning up all created services
2024/12/13 09:17:29 Shutting down InfluxReporter
2024/12/13 09:17:29 SLA 1 failed. Errors occurred: 1

Not sure if we can verify it here. Could you take a look on this one too? Btw I will stamp it based on the other test.

[maschmid]

Trying to see if #15654 helps with the SLA 1

[maschmid]

included in #15654