Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump contour to 1.30.1 #1149

Merged
merged 3 commits into from
Jan 10, 2025
Merged

bump contour to 1.30.1 #1149

merged 3 commits into from
Jan 10, 2025

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Dec 21, 2024 •
edited
Loading

  • adjust linter settings
  • bump contour to 1.30.1

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto December 21, 2024 02:04
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 21, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.34%. Comparing base (dfffc8f) to head (f5b2c37).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1149   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files          11       11           
  Lines         938      938           
=======================================
  Hits          885      885           
  Misses         32       32           
  Partials       21       21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 21, 2024
@dprotaso dprotaso changed the title bump contour and drop go.mod replace directive bump contour to 1.30.1 Dec 21, 2024
@dprotaso
Copy link
Contributor Author

Looks like there's a regression with contour v1.30.1 and a bunch of our tests

@dprotaso
Copy link
Contributor Author

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2024
@dprotaso
Copy link
Contributor Author

Asked if there are known issues here - https://kubernetes.slack.com/archives/C8XRH2R4J/p1734754791329519

Unfortunately, don't have time to investigate this

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 29, 2024
@dprotaso dprotaso mentioned this pull request Jan 9, 2025
Closed
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2025
@dprotaso
Copy link
Contributor Author

dprotaso commented Jan 9, 2025

/retest

@dprotaso dprotaso force-pushed the bump-contour branch 2 times, most recently from c0ebfc8 to f5b2c37 Compare January 9, 2025 04:56
@dprotaso
Copy link
Contributor Author

dprotaso commented Jan 9, 2025

/assign @skonto

@dprotaso
Copy link
Contributor Author

dprotaso commented Jan 9, 2025

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
This was referenced Jan 9, 2025
Open
Merged
Merged
@skonto
Copy link
Contributor

skonto commented Jan 10, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 2f97943 into knative-extensions:main Jan 10, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode Awaiting requested review from ReToCode

@skonto skonto Awaiting requested review from skonto

Assignees

@skonto skonto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dprotaso @skonto @knative-prow-robot