Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter fixes #1034

Merged
merged 5 commits into from
Jan 10, 2025
Merged

linter fixes #1034

merged 5 commits into from
Jan 10, 2025

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jan 10, 2025

Linter fixes on #1033

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@knative-prow knative-prow bot requested review from izabelacg and skonto January 10, 2025 04:12
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.14%. Comparing base (61c6cb6) to head (4957ba2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/apis/networking/v1alpha1/ingress_helpers.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1034   +/-   ##
=======================================
  Coverage   93.14%   93.14%           
=======================================
  Files          36       36           
  Lines        1254     1255    +1     
=======================================
+ Hits         1168     1169    +1     
  Misses         72       72           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 10, 2025
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 10, 2025
@dprotaso
Copy link
Member Author

/assign @skonto

@dprotaso
Copy link
Member Author

contour failure is because the deps are pinned - we can unpin them after this PR merges - knative-extensions/net-contour#1149

@skonto
Copy link
Contributor

skonto commented Jan 10, 2025

/retest

@skonto
Copy link
Contributor

skonto commented Jan 10, 2025

contour failure is because the deps are pinned - we can unpin them after this PR merges

Which deps?

@skonto
Copy link
Contributor

skonto commented Jan 10, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
Copy link

knative-prow bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link
Contributor

skonto commented Jan 10, 2025

/retest

@dprotaso
Copy link
Member Author

net-contour downstream test this will fail until it has newer k8s libs

@knative-prow knative-prow bot merged commit 22a6457 into knative:main Jan 10, 2025
27 checks passed
@dprotaso
Copy link
Member Author

this merged due to this bug - kubernetes-sigs/prow#356

@dprotaso
Copy link
Member Author

or wait it passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants