-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linter fixes #1034
linter fixes #1034
Conversation
1e1f618
to
da5fcf6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1034 +/- ##
=======================================
Coverage 93.14% 93.14%
=======================================
Files 36 36
Lines 1254 1255 +1
=======================================
+ Hits 1168 1169 +1
Misses 72 72
Partials 14 14 ☔ View full report in Codecov by Sentry. |
/assign @skonto |
contour failure is because the deps are pinned - we can unpin them after this PR merges - knative-extensions/net-contour#1149 |
/retest |
Which deps? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
net-contour downstream test this will fail until it has newer k8s libs |
this merged due to this bug - kubernetes-sigs/prow#356 |
or wait it passed |
Linter fixes on #1033