This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
fix: check numbers of calls multicall precompile #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
precompile
ClementWalter
approved these changes
Nov 29, 2024
ClementWalter
pushed a commit
that referenced
this pull request
Dec 5, 2024
The fix made previously in #1647 did not take into account that the starknet state might have been changed. If we ever encounter a case where the multicall payload was wrongly formed and the number of executed calls doesn't match the input, we should revert the tx immediately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
precompile
Time spent on this PR:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #
What is the new behavior?
Check the number of expected calls is equal to the number of actual calls made