fix: revert tx if multicall input is incoherent #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
changed the title
enitrat
force-pushed
the
fix/revert-incoherent-multicall
branch
from
b937f9e to
4ae241a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1655 +/- ##
=======================================
- Coverage 64.2% 63.9% -0.3%
=======================================
Files 44 44
Lines 8341 8338 -3
=======================================
- Hits 5355 5335 -20
- Misses 2986 3003 +17 ☔ View full report in Codecov by Sentry. |
enitrat
force-pushed
the
fix/revert-incoherent-multicall
branch
from
4ae241a to
8d98d93
Compare
ClementWalter
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix made previously in #1647 did not take into account that the starknet state might have been changed.
If we ever encounter a case where the multicall payload was wrongly formed and the number of executed calls doesn't match the input, we should revert the tx immediately.