Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lyric transformer issue #1293

Merged
merged 7 commits into from
May 5, 2022
Merged

Fix lyric transformer issue #1293

merged 7 commits into from
May 5, 2022

Conversation

andy840119
Copy link
Member

Upgrade the package to fix issue like karaoke-dev/osu-framework-font#177

@andy840119 andy840119 added bug Something isn't working skin About skin resource 3rd Third-party support labels May 5, 2022
@andy840119
Copy link
Member Author

image
Guess still not fixing that because change the shader not re-calculate the transforms.
Not really sure why not happened in the lyric editor.

@andy840119
Copy link
Member Author

But it's still OK to give it a merge.
Seems no feature breaking.

@andy840119 andy840119 merged commit ddc66f3 into karaoke-dev:master May 5, 2022
@andy840119 andy840119 deleted the fix-lyric-transformer-issue branch May 5, 2022 13:16
@andy840119 andy840119 mentioned this pull request May 5, 2022
Closed
@andy840119
Copy link
Member Author

Will make a new release until this issue has been fixed.

@andy840119 andy840119 mentioned this pull request May 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3rd Third-party support bug Something isn't working size/L skin About skin resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andy840119