Separate the auto-generate logic in the LyricAutoGenerateChangeHandler. #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge.
…create the generator or detector.
Need to test the behavior that inherit the ILyricPropertyAutoGenerateChangeHandler instead.
|
Use one change handler to edit one property does not means one property only has exactly one generator Orz. |
andy840119
added a commit
to andy840119/karaoke
that referenced
this pull request
Sep 26, 2023
means revert the change in the karaoke-dev#1958.
andy840119
added a commit
to andy840119/karaoke
that referenced
this pull request
Sep 27, 2023
means revert the change in the karaoke-dev#1958.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #1957.
As we are already use one change handler to edit one property in the lyric, we should move the auto-generator logics into those change handlers.