Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github action for upload the localisation to crowdin. #1369

Merged
merged 4 commits into from
Jun 10, 2022
Merged

Add github action for upload the localisation to crowdin. #1369

merged 4 commits into from
Jun 10, 2022

Conversation

andy840119
Copy link
Member

Closes issue #1368

@andy840119 andy840119 added the enhancement New feature or request label Jun 10, 2022
@andy840119 andy840119 marked this pull request as ready for review June 10, 2022 12:40
@andy840119
Copy link
Member Author

andy840119 commented Jun 10, 2022 •
edited
Loading

Guess there's no way to test it.
sad.

update:
image
CI works.
Should be super dangerous but nice.

@andy840119 andy840119 force-pushed the add-ci-for-upload-the-localisation branch 3 times, most recently from 123039d to 33d952d Compare June 10, 2022 12:55
@andy840119
Add the source setting to get the localization file.
22c733b 
And notice that there's no need to checkout the repo.
Just need to upload the file.
@andy840119 andy840119 force-pushed the add-ci-for-upload-the-localisation branch 3 times, most recently from 5b45470 to bc9c956 Compare June 10, 2022 13:31
@andy840119
Copy link
Member Author

andy840119 commented Jun 10, 2022 •
edited
Loading

幹您娘 crowdin 的 document 可以寫得爛一點沒關係

image
Damn there's no way to test with the remote branch, my bad.

@andy840119 andy840119 force-pushed the add-ci-for-upload-the-localisation branch from bc9c956 to 22c733b Compare June 10, 2022 13:38
@andy840119
Copy link
Member Author

Guess it should be OK to give it a merge.

@andy840119 andy840119 merged commit fe146ee into karaoke-dev:master Jun 10, 2022
@andy840119 andy840119 deleted the add-ci-for-upload-the-localisation branch June 10, 2022 13:39
@andy840119 andy840119 mentioned this pull request Jun 10, 2022
Merged
@andy840119 andy840119 added this to the 2022.0625 milestone Jun 10, 2022
@andy840119 andy840119 mentioned this pull request Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request size/M
Projects
None yet
Milestone
2022.0625
Development

Successfully merging this pull request may close these issues.
1 participant
@andy840119