Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make a CI for checking if user generated the localization resource file #1269

Closed
andy840119 opened this issue Apr 12, 2022 · 2 comments
Closed

make a CI for checking if user generated the localization resource file #1269

andy840119 opened this issue Apr 12, 2022 · 2 comments
Labels
enhancement New feature or request localization Translation related.
Milestone
2022.0716

Comments

@andy840119
Copy link
Member

Inspired from #1268

Make the hint like this:

run the comment to generate the localization file:
dotnet tool restore
dotnet localisation to-resx ./osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj
@andy840119 andy840119 added enhancement New feature or request localization Translation related. labels Apr 12, 2022
@andy840119
Copy link
Member Author

Also, not really should be better to change the .resx file location?
Because not be a good idea to mix the code and resource file.
image

@andy840119 andy840119 added this to the 2022.0716 milestone Jul 1, 2022
@andy840119
Copy link
Member Author

Implemented in the #1369 and duplicated with #1368.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request localization Translation related.
Projects
None yet
Milestone
2022.0716
Development

No branches or pull requests
1 participant
@andy840119