Playing Directly from Artist Page #493

BobcatNoah · 2023-09-02T23:40:25Z

Implements #424

Adds a button to play all albums of an artist in both offline mode and online mode. Previously, the artist view in offline mode would just show up as a white screen if albums from multiple artists were downloaded. I had to add a bit of code to music_screen_tab_view.dart to make sure only the albums corresponding with the artist show up. Otherwise all downloaded albums in offline mode would show up in each individual artist view.

Also, how do I setup the environment for the redesign branch? I would have written the code in the redesign branch, but I couldn't get that branch to build. I suspect I just set up the environment incorrectly.

Before:

After:

jmshrv · 2023-09-04T03:38:38Z

Nice, this has been a little thing that should have been added years ago 🙃

How does it work in offline mode? The code looks like you're figuring it out from downloaded parents, which is a pretty clever way around the lack of "real" downloaded artists.

As for the redesign branch, what error are you getting? A new Flutter version may have broken things, in theory it should "just work" as main does

BobcatNoah · 2023-09-04T18:03:51Z

First of all, it iterates through the downloaded songs, selects those by the current artist in view, and stores them in the songs list. It then groups these songs by album ID in a map called groupedSongs. It sorts the songs within each album by their index number. Finally, it converts the map into a list, which the queue is replaced with when you click the play button.

The error I'm getting is this.

Because finamp depends on flutter_localizations from sdk which depends on intl
  0.17.0, intl 0.17.0 is required.
So, because finamp depends on intl ^0.18.0, version solving failed.
pub get failed

Here is the output of flutter --version.

Flutter 3.7.12 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 4d9e56e694 (5 months ago) • 2023-04-17 21:47:46 -0400
Engine • revision 1a65d409c7
Tools • Dart 2.19.6 • DevTools 2.20.1

BobcatNoah · 2023-09-05T14:49:45Z

So, I got the redesign branch to build using flutter 3.10.5. However, whenever I open the music player, the app freezes and flutter: 80008 -3.4227457425910472 is printed to the console thousands of times per second with that first value increasing.

Chaphasilor · 2023-09-05T14:59:08Z

@BobcatNoah just switch to dark mode in settings :)
The contrast calculation is currently borked and never finishes in light mode 😅

BobcatNoah · 2023-09-05T16:57:19Z

@Chaphasilor Thanks. That fixed it for me.

jmshrv · 2023-09-06T02:40:47Z

That's a pretty clever solution to showing artists :)

Do you plan on doing something similar to show the artists list in offline mode? Currently, the offline functionality of the artist play button won't be reachable.

BobcatNoah · 2023-09-06T02:49:14Z

It wasn't my original plan to implement the artists list in offline mode, but I guess I could try implementing it. I can't guarantee that I'll be able to do it in a timely manner.

Also, it technically is reachable by going to an album and clicking on the artist's name.

jmshrv · 2023-09-06T12:31:43Z

I wouldn't mind working on it myself, it's been a while since I've seriously worked on Finamp

BobcatNoah · 2023-09-29T13:43:42Z

Btw, I'm done with this pull request and I'm not planning to add any more code to it.

jmshrv · 2023-09-29T20:21:33Z

Would this be mergable then? Sounds like it's in a good state

Chaphasilor · 2023-09-29T21:33:28Z

Just left a review, if you feel like making some changes. Otherwise I'll take a look at it myself tomorrow and make some minor improvements :)

jmshrv · 2023-09-30T11:07:54Z

Just left a review, if you feel like making some changes. Otherwise I'll take a look at it myself tomorrow and make some minor improvements :)

I'm not seeing it in the Files Changed tab, did you remember to submit it? 🙃

Chaphasilor · 2023-09-29T21:28:54Z

lib/components/ArtistScreen/artist_play_button.dart

+             final List<BaseItemDto>songs = [];
+
+             for (DownloadedSong item in downloadsHelper.downloadedItems) {
+              if (item.song.albumArtist == widget.artist.name) {
+                songs.add(item.song);
+              }
+             }
+
+             // We have to sort by hand in offline mode because a downloadedParent for artists hasn't been implemented
+             Map<String, List<BaseItemDto>> groupedSongs = {};
+             for (BaseItemDto song in songs) {
+              groupedSongs.putIfAbsent((song.albumId ?? 'unknown'), () => []);
+              groupedSongs[song.albumId]!.add(song);
+             }


Can this be done in a single loop? There could be 10k+ downloaded songs

I feel like this is a non-issue. The code only iterates through the entire library one. After that, the code uses the songs variable which only contains a list of songs by the artist (so the songs variable will only ever hold at most a few hundred songs). I also just renamed the variable to better reflect that.

Chaphasilor · 2023-09-29T21:30:27Z

lib/components/ArtistScreen/artist_play_button.dart

+             groupedSongs.forEach((album, albumSongs) {
+               albumSongs.sort((a, b) => (a.indexNumber ?? 0).compareTo(b.indexNumber ?? 0));
+             });
+
+             final List<BaseItemDto> sortedSongs = [];
+             groupedSongs.values.forEach((albumSongs) {
+               sortedSongs.addAll(albumSongs);
+             });


Same for this. After sorting, add the albumSongs to sortedSongs right away

Chaphasilor · 2023-09-29T21:32:30Z

lib/screens/artist_screen.dart

@@ -28,6 +29,7 @@ class ArtistScreen extends StatelessWidget {
        title: Text(artist.name ?? "Unknown Name"),
        actions: [
          // this screen is also used for genres, which can't be favorited
+          if (artist.type != "MusicGenre") ArtistPlayButton(artist: artist),


What about adding a shuffle button as well?

Chaphasilor · 2023-09-30T11:10:34Z

@jmshrv thanks for letting me know, I used the mobile app and didn't notice the review wasn't submitted yet...

jmshrv · 2023-09-30T11:51:12Z

btw I don't have push access to the fork, but the changes are relatively minor so it isn't the end of the world :)

BobcatNoah · 2023-10-02T02:57:15Z

I added the shuffle button, however I noticed that it always will play a certain song first. Everything else is shuffled though.

Chaphasilor · 2023-10-02T06:53:20Z

I added the shuffle button, however I noticed that it always will play a certain song first. Everything else is shuffled though.

Hmm, this shouldn't be happening since #442 got merged, I wonder what this is about. Still, better than nothing ^^

jmshrv · 2023-10-02T09:37:35Z

Yeah shuffling is a nightmare for some reason, I'll merge this since the code looks good (we're just nitpicking) :)

BobcatNoah added 4 commits August 31, 2023 21:58

Feature Add: Play Directly from artist page

5561722

Fixed Genre tab

6f56c7a

Improved artist offline implementation

80715a6

Fixed artist offline view (not artist tab) & queue

89ecb32

Extra Null Safety

f5796c7

Chaphasilor reviewed Sep 30, 2023

View reviewed changes

Add shuffle button

141f029

jmshrv merged commit 028b251 into jmshrv:main Oct 2, 2023

Chaphasilor mentioned this pull request Nov 23, 2023

Weird Album Sorting on Artist Page #536

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Playing Directly from Artist Page #493

Playing Directly from Artist Page #493

BobcatNoah commented Sep 2, 2023

jmshrv commented Sep 4, 2023

BobcatNoah commented Sep 4, 2023 •

edited

Loading

BobcatNoah commented Sep 5, 2023

Chaphasilor commented Sep 5, 2023

BobcatNoah commented Sep 5, 2023

jmshrv commented Sep 6, 2023

BobcatNoah commented Sep 6, 2023

jmshrv commented Sep 6, 2023

BobcatNoah commented Sep 29, 2023

jmshrv commented Sep 29, 2023

Chaphasilor commented Sep 29, 2023 •

edited

Loading

jmshrv commented Sep 30, 2023

Chaphasilor Sep 29, 2023

BobcatNoah Oct 1, 2023

Chaphasilor Sep 29, 2023

Chaphasilor Sep 29, 2023

Chaphasilor commented Sep 30, 2023

jmshrv commented Sep 30, 2023

BobcatNoah commented Oct 2, 2023

Chaphasilor commented Oct 2, 2023

jmshrv commented Oct 2, 2023

Playing Directly from Artist Page #493

Playing Directly from Artist Page #493

Conversation

BobcatNoah commented Sep 2, 2023

jmshrv commented Sep 4, 2023

BobcatNoah commented Sep 4, 2023 • edited Loading

BobcatNoah commented Sep 5, 2023

Chaphasilor commented Sep 5, 2023

BobcatNoah commented Sep 5, 2023

jmshrv commented Sep 6, 2023

BobcatNoah commented Sep 6, 2023

jmshrv commented Sep 6, 2023

BobcatNoah commented Sep 29, 2023

jmshrv commented Sep 29, 2023

Chaphasilor commented Sep 29, 2023 • edited Loading

jmshrv commented Sep 30, 2023

Chaphasilor Sep 29, 2023

Choose a reason for hiding this comment

BobcatNoah Oct 1, 2023

Choose a reason for hiding this comment

Chaphasilor Sep 29, 2023

Choose a reason for hiding this comment

Chaphasilor Sep 29, 2023

Choose a reason for hiding this comment

Chaphasilor commented Sep 30, 2023

jmshrv commented Sep 30, 2023

BobcatNoah commented Oct 2, 2023

Chaphasilor commented Oct 2, 2023

jmshrv commented Oct 2, 2023

BobcatNoah commented Sep 4, 2023 •

edited

Loading

Chaphasilor commented Sep 29, 2023 •

edited

Loading