-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird Album Sorting on Artist Page #536
Comments
Oh, interesting -- thanks for the response! I hadn't seen #448, and that
looks most likely to be the culprit, but when I look at the metadata on
Jellyfin, literally only one of the albums has a release date, and that's
the 2022 one (which appears last). So I'm not sure what's going on?
…On Thu, Nov 23, 2023 at 3:03 AM Chaphasilor ***@***.***> wrote:
That might've been #448 <#448> or
#493 <#493>
Could you check the full metadata in Jellyfin to see what the PremiereDate
of these albums is, compared to the production year?
—
Reply to this email directly, view it on GitHub
<#536 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APV3DXJKVRC2ZBF7OGLVDGDYF37MPAVCNFSM6AAAAAA7XI5VB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRTHE2DMNJYG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
And doing a quick survey of other artists, it seems like it's correctly
sorting albums that have release dates filled in -- but for those that only
have a year, I can't find rhyme or reason to the order it decides on.
On Thu, Nov 23, 2023 at 3:34 AM Sebastian J. Garza <
***@***.***> wrote:
… Oh, interesting -- thanks for the response! I hadn't seen #448, and that
looks most likely to be the culprit, but when I look at the metadata on
Jellyfin, literally only one of the albums has a release date, and that's
the 2022 one (which appears last). So I'm not sure what's going on?
On Thu, Nov 23, 2023 at 3:03 AM Chaphasilor ***@***.***>
wrote:
> That might've been #448 <#448> or
> #493 <#493>
>
> Could you check the full metadata in Jellyfin to see what the
> PremiereDate of these albums is, compared to the production year?
>
> —
> Reply to this email directly, view it on GitHub
> <#536 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APV3DXJKVRC2ZBF7OGLVDGDYF37MPAVCNFSM6AAAAAA7XI5VB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRTHE2DMNJYG4>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
If there is no release date provided, the order is most likely just random, as you are observing. We should fall back to sorting by production year and then name I think |
Yes, I think that would make the most sense! Preferably by taking any blank
release dates to be YEAR-01-01, so it gets sorted in with the dates ones,
if that makes sense.
…On Thu, Nov 23, 2023 at 6:34 AM Chaphasilor ***@***.***> wrote:
If there is no release date provided, the order is most likely just
random, as you are observing. We should fall back to sorting by production
year and then name I think
—
Reply to this email directly, view it on GitHub
<#536 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APV3DXMYVPGF3JI7PTCS7HTYF4YF7AVCNFSM6AAAAAA7XI5VB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRUGI3TCNBWGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@Maxr1998 once mentioned that the server will fall back to sorting by year if it can't sort by date. So this issue is a bit confusing. |
I remember doing two PRs for this issue, since some changes were undone in between. Maybe that's just an artifact of that, and not actually an issue? @TinDefacto could you verify whether it's still an issue on the latest version? And yes, the current settings also work if just a production year is set on the album, and the PremiereDate is missing. |
Hi! Okay, thanks so much for your work on this -- though I think it still
needs a bit more work!
Some artists on my server (like those that have multiple releases per year)
have full release dates for each album -- these are now displayed in
perfect chronological order, which is immaculate.
However! For other artists I either have a mix of exact release dates or
blank ones (i.e. just the release year) or only years for each release, no
exact release date. These it seems to just be putting in alphabetical order
by album name, which is very much not what I want.
What I feel might be a good solution is to, for albums with only years and
no release date, sort it by release date by filling in the missing ones
with YYYY-01-01 (or something similar). Does that seem reasonable/doable?
Thank you again!!
…On Wed, Nov 13, 2024 at 9:36 AM Max Rumpf ***@***.***> wrote:
I remember doing two PRs for this issue, since some changes were undone in
between. Maybe that's just an artifact of that, and not actually an issue?
@TinDefacto <https://github.com/TinDefacto> could you verify whether it's
still an issue on the latest version?
—
Reply to this email directly, view it on GitHub
<#536 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APV3DXPK5LTWYEQRH5OCRS32ANPWDAVCNFSM6AAAAABRWTYABOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZTHAYDAMRRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
As the sorting is done on the server side (except when offline), I suppose it should be fixed there instead. But thanks for reporting it, I'll give it a look when I find some time. |
Hi there!
Some recent update -- I'm not sure which one -- sent the sorting of albums on an artist's page all out of wack. Now the order of an artist's releases may be (as in one case for me) 2021, 2016, 2019, 2013, 2020, 2013, 2011, 2014, 2019, 2016, 2022. It's not even alphabetical, so I'm really confused! I really appreciated the previous chronological order, and I don't see this issue being raised elsewhere, so I figured I'd point it out.
Thanks again for all the work y'all do. :)
The text was updated successfully, but these errors were encountered: