Fix shuffle always starts on first song(issues:#61) and remove redund… #442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #61
We pick a random item and put it first, instead of putting the first one first every time. And In order to make initialIndex take effect in updateQueue → _player.setAudioSource, I removed the if judgment in the replaceQueueWithItem method.
I remove _player.shuffle() when setShuffleMode(AudioServiceShuffleMode.all). It's redundant. I see the just_audio src code. When we invoke setAudioSource() method and proload is true, just_audio will call _load() method. AudioSource will be shuffled here. And platform.load() will send audioSourceMessage, initialPosition, initialIndex to native layer program.Actually audioSourceMessage contains shuffleOrder information. You can see just_audio-0.9.32/android/src/main/java/com/ryanheise/just_audio/AudioPlayer.java
at case concatenating part.
I see when I click block(or named stop) button on bottom bar. The current music always autochanged to album/playlist first item. Is this this app feature, or a bug?