Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a shortcut to system equalizer. (Only works on android) #334

Closed
wants to merge 1 commit into from

Conversation

Y0ngg4n
Copy link
Contributor

@Y0ngg4n Y0ngg4n commented Sep 23, 2022

Added a check if system is android

@jmshrv
Copy link
Owner

jmshrv commented Oct 8, 2022

This isn't too useful imo, the user can get to their equaliser in their system settings. If I ever get around to #177, we could likely implement an equaliser in Finamp that will support all platforms

@jmshrv jmshrv closed this Oct 8, 2022
@Y0ngg4n
Copy link
Contributor Author

Y0ngg4n commented Oct 8, 2022

Most People dont know about the system Equalizer. I dont know how we could implement it for all platforms.

@jmshrv
Copy link
Owner

jmshrv commented Oct 8, 2022

If my plans to use GStreamer as a player backend work, we could implement it in the player: https://gstreamer.freedesktop.org/documentation/equalizer/index.html

Another thing to note is that not all Android skins have a system equaliser, and from quick look at the Equalizer package it looks like there isn't a way to determine this.

@Y0ngg4n
Copy link
Contributor Author

Y0ngg4n commented Oct 9, 2022

ah ok thank you :)

@Y0ngg4n
Copy link
Contributor Author

Y0ngg4n commented Oct 9, 2022

But i guess there is no gstreamer package we can use so we have to implement it our selves right?

@jmshrv
Copy link
Owner

jmshrv commented Oct 11, 2022

Yeah, my initial idea is to make a just_audio implementation that uses GStreamer. It's pretty far off, but it'll be really nice once it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants