Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .lrc files + Equalizer #274

Closed
0xN0BADC0FF33 opened this issue Jul 14, 2022 · 10 comments
Closed

Support .lrc files + Equalizer #274

0xN0BADC0FF33 opened this issue Jul 14, 2022 · 10 comments

Comments

@0xN0BADC0FF33
Copy link

Support synchronized lyrics with music and equalizer (10band if possible)

@jmshrv
Copy link
Owner

jmshrv commented Jul 14, 2022

I'd have to see if Jellyfin itself supports lyrics but it would be nice. Equaliser support would be dependant on ryanheise/just_audio#147

@florinsdistortedvision
Copy link

Def lyrics support would be great, especially synced ones. Imo the only thing that's missing to make this app killer.

@0xN0BADC0FF33
Copy link
Author

https://www.zerobin.tk/?129e8bd9d0d20944#EsMEmNbdE2UsuE5Wj5ymafdUXBsqKSxdiwYeftPy7t7y

This is part of a ffmpeg transcode log. It's sending the existing .lrc file with it. So should be possible :)

@Chaphasilor
Copy link
Collaborator

It's sending the existing .lrc file with it. So should be possible :)

Are you sure the lyrics aren't already embedded in the file itself as a tag? What happens when you delete the .lrc file?

Also, even if it really loads the lyrics from the .lrc file, that seems to only be the case when transcoding, and not when direct playing.
Otherwise, plugins like Jellylyrics wouldn't be needed.

The dev already said that they are looking into Lyrics support via this plugin, so it should be supported eventually.

@florinsdistortedvision
Copy link

Yeah those look embedded to the file. What I'm looking for is having:

Song.format (like song.mp3)
Song.lrc

Both in the same folder. Have it auto recognize and show the lyrics.

@0xN0BADC0FF33
Copy link
Author

My bad, sorry! It's really implemented in the file. I have done both, implement it and save it as .lrc

@Chaphasilor
Copy link
Collaborator

Yeah those look embedded to the file. What I'm looking for is having:

Song.format (like song.mp3)
Song.lrc

Both in the same folder. Have it auto recognize and show the lyrics.

Yeah that completely depends on Jellyfin / server-side support.

@jmshrv
Copy link
Owner

jmshrv commented Sep 10, 2022

@Y0ngg4n
Copy link
Contributor

Y0ngg4n commented Sep 23, 2022

#334

@jmshrv jmshrv mentioned this issue May 29, 2023
@jmshrv
Copy link
Owner

jmshrv commented May 29, 2023

EQ will be tracked at #453, closing this issue as #338 has had more discussion on lyrics

@jmshrv jmshrv closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants