Clean up HTTP authentication reference and Update constructors #562
Conversation
2. Update constructors in JiraSite.java and JireSiteTest.java 3. Leave the `@Deprecated` annotation in case any error should occur
| @@ -263,7 +263,8 @@ public JiraSite( | |||
| boolean updateJiraIssueForAllStatus, | |||
| @CheckForNull String groupVisibility, | |||
| @CheckForNull String roleVisibility, | |||
| boolean useHTTPAuth) { | |||
| boolean useHTTPAuth, | |||
There was a problem hiding this comment.
Let's remove all deprecated constructors, it they are there for quite a while.
There was a problem hiding this comment.
Revision finished, waiting for your review!
| @@ -1417,6 +1396,7 @@ static class Builder { | |||
| private String groupVisibility; | |||
| private String roleVisibility; | |||
| private boolean useHTTPAuth; | |||
There was a problem hiding this comment.
Revision finished, waiting for your review!
| @@ -647,7 +623,8 @@ protected Object readResolve() { | |||
| updateJiraIssueForAllStatus, | |||
| groupVisibility, | |||
| roleVisibility, | |||
| useHTTPAuth); | |||
| useHTTPAuth, | |||
There was a problem hiding this comment.
@olamy I think this whole if migration block is there for a long time as well, everyone should have already migrated those credentials so I propose to drop this whole if as well?
|
Is there anything I should do toward this pull request? @rantoniuk |
|
I don't remember if this is serialized or not? because changing a field will break existing configuration |
|
@olamy correct me if I'm wrong, but from what I remember, everything that is not So we would need to:
(or alternatively again write some "migrator" that we did already in the past, but I'm just looking for a simpler solution..) When I have some time, I'll try to run some local tests to see which approach works, but maybe you already know what to suggest. |
@Deprecatedannotation in case any error should occur