Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up HTTP authentication code references #541

Open
rantoniuk opened this issue May 14, 2023 · 5 comments
Open

Clean up HTTP authentication code references #541

rantoniuk opened this issue May 14, 2023 · 5 comments

Comments

@rantoniuk
Copy link
Contributor

Clean up HTTP Auth references from the code based on the discussion in #521 (comment)_

@akshaywakhare
Copy link

Hi. I would like to give this a try, can I work on this?

@rantoniuk
Copy link
Contributor Author

Of course, you're welcome to contribute!

@xRME-18
Copy link

xRME-18 commented May 23, 2023

Hey, what should be done with all the (deprecated) functions using useHTTPAuth? Should I update the functions with useBearerAuth or remove them entirely? Sorry if its obvious, I'm new to this.

@programbeginnerTW
Copy link

programbeginnerTW commented Jul 16, 2023

Hi, I looked through the mentioned issue above and concluded the disscussion:

  1. Bearer Authentication is only allowed on Jira Server but not on Jira cloud.
  2. HTTP auth as well as Bearer auth should both exist to meet the requirements of 1.

Hence, I removed the invisibleEntry section of HTTP in the config.jelly file and updated the constructors in file JiraSite.java, as well as the JiraSiteTest.java by adding useBearerAuth.
If I'm misunderstanding the issue, please offer more instructions on how I can contribute to this issue, thanks!

Here is my Pull Request: #562

@abhishekshah5486
Copy link

I would like to work on this issue.
Please assign this issue to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants