Head requests for server discovery #943
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally add the result of an HTTP redirect to the discovered servers during the remote discovery process, but only if the redirect stays on the same domain.
Resolves #471
Adds head requests to the ApiClient and loosens the requirement to return OK status by allowing a specified range. The redirect logic is contained in RecommendedServerDiscovery, supported by a new RecommendedServerIssue to slightly prefer non-redirected addresses. If an address was found as the result of following a redirect, its RecommendedServerInfo will include the original address, and a new method isRedirect() returns true.