Follow HTTP redirect in remote discovery #929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 17, 2024 20:17
…ubpath of the original. Adds a parameter to RecommendedServerDiscovery.discover() that indicates if we should follow a redirect from the given servers. If true, send a HEAD request to the given servers, and if it returns a redirect code then add the redirect location to the collection of servers to check, but only if the redirected location is on the same host as the original. Prefer non-redirected addresses over those that are the result of a redirect. Pass the original and possible redirected address back through the RecommendedServerInfo object for use.
Use the Headers object instead of a standard map to provide case-insensitive access to the headers. Correctly override the path on the current URL when given a path-only redirect
|
If I'm understanding the api code generation correctly, Api objects like systemApi that do most/all of the requests currently are generated based off the server api, so we can't add a head request to those, and therefore it's ok to do the head request directly through the KtorClient |
jellyfin-api/src/commonMain/kotlin/org/jellyfin/sdk/api/client/ApiClient.kt
Show resolved
Hide resolved
|
see #943 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally add the result of an HTTP redirect to the discovered servers during the remote discovery process, but only if the redirect stays on the same domain.
Resolves #471
Currently done by adding a HEAD request method to the KtorClient, because the generic request method requires an OK status. If this will remain, there is the opportunity to extract common code to reduce the current duplication, but this may also change as a result of bringing this code in line with the existing api patterns.