refactor: change to use AWS SDK v3 signing package #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks for this @nguyentoanit! I will review and hopefully merge shortly. |
|
🎉 This PR is included in version 2.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hey @nguyentoanit - I had to revert these changes unfortunately. It seems to be causing a number of issues in the integration tests so I've backed it out for now. These don't run in the automated builds at the moment but you can run them locally with: yarn run test-it:deploy
yarn run test-itI don't really have the capacity to investigate these failures right now but let me know if you find anything! |
jamesmbourne
added a commit
that referenced
this pull request
Aug 9, 2021
* fix: Revert "fix: remove package-lock.json and regenerate yarn.lock (#291)" This reverts commit 430246c. * fix: Revert "Merge branch 'refactor/change-aws4-axios-to-use-aws-sdk-signing-package' of https://github.com/ScaleLeap/aws4-axios" This reverts commit 61048c3, reversing changes made to 72d3fc7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS SDK v3 was officially released: https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/
I think it would be better if we refactor to use
@aws-sdk/signature-v4for signing package.Closes #35