Skip to content

Commit

Permalink
fix: revert #196 and #291 (#292)
Browse files Browse the repository at this point in the history
* fix: Revert "fix: remove package-lock.json and regenerate yarn.lock (#291)"

This reverts commit 430246c.

* fix: Revert "Merge branch 'refactor/change-aws4-axios-to-use-aws-sdk-signing-package' of https://github.com/ScaleLeap/aws4-axios"

This reverts commit 61048c3, reversing
changes made to 72d3fc7.
  • Loading branch information
jamesmbourne authored Aug 9, 2021
1 parent 430246c commit 46b38f0
Show file tree
Hide file tree
Showing 6 changed files with 3,847 additions and 2,850 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Node.js CI

on: [pull_request]
on: [pull_request_target]

jobs:
build:
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
},
"dependencies": {
"@aws-sdk/client-sts": "^3.4.1",
"@aws-sdk/signature-v4": "^3.4.1"
"@types/aws4": "^1.5.1",
"aws4": "^1.9.1"
},
"peerDependencies": {
"axios": ">0.19.2 < 0.22.0"
Expand Down
2 changes: 1 addition & 1 deletion src/axiosInterceptor.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ describe("axios interceptor", () => {
const request = moxios.requests.first();
expect(request.headers["Content-Type"]).toEqual("application/json");
expect(request.headers["X-Custom-Header"]).toEqual("foo");
expect(request.headers["authorization"]).toContain("AWS");
expect(request.headers["Authorization"]).toContain("AWS");
});

it("should preserve default headers - without interceptor", async () => {
Expand Down
Loading

0 comments on commit 46b38f0

Please sign in to comment.