lag: Remove 'lag' link type, cleanup virtual links #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipspace
requested changes
Dec 13, 2024
|
Also, what happened to "I will submit a PR when I'm done programming"? Got three notifications about this PR. |
jbemmel
force-pushed
the
remove-lag-link-type
branch
from
4702a67 to
c812b6c
Compare
jbemmel
force-pushed
the
remove-lag-link-type
branch
5 times, most recently
from
43d736c to
3fd9f11
Compare
|
Please resolve the merge conflicts first. Thank you! |
jbemmel
force-pushed
the
remove-lag-link-type
branch
from
ce43daf to
c0adea1
Compare
|
Looks like you're still working on this one. Change it to "ready for review" when you're done. |
jbemmel
force-pushed
the
remove-lag-link-type
branch
from
dc9eae3 to
0d182ec
Compare
|
What's going on with this one? Is it ready to merge (I won't even try to review it)? |
Waiting on the other lag PR to be merged, then I'll update this one |
* Modify lag member lag._parentindex to match lag.ifindex, not linkindex
…on intf.linkindex, not intf.lag.ifindex
…g interfaces get created * Fix the moment lag interfaces get created: After interface attribute validation, but before vlan pre link transformation callbacks Some issue remains with IP addresses being allocated to lag interfaces instead of vlan SVI
TODO: Validate all VLAN cases with/without lag
…er lag interfaces are created
* vlan-link-error: Now correctly identifying 'irb' as an invalid value, but hiding the mismatch in vlan.access name * vlan-trunk-attribute-error: Instead of identifying 'bgp' as being not enabled, 'bgp.as' is determined to be an invalid irb interface attribute
* Fix interface attribute inheritance
* Expand L3 test case to include gateway and custom IP settings
Update test results
In multi-provider scenario's, link.type is changed resulting in virtual lag links not being removed
jbemmel
force-pushed
the
remove-lag-link-type
branch
from
128221d to
13bf985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conceptually a 'lag' link type does not make a whole lot of sense; the
lagmodule temporarily uses a link object as a grouping construct until the node lag interfaces are created, but there is no reason to keep this around once that is doneThis PR cleans things up a little:
lag.ifindex, notlinkindex(which is now removed from the lag interface)Includes various bug fixes: